From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [RFC] swap event handling fixes Date: Fri, 29 Apr 2011 14:37:14 -0700 Message-ID: <20110429143714.517e0f67@jbarnes-desktop> References: <1304022442-8070-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1304022442-8070-1-git-send-email-jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Errors-To: xorg-devel-bounces+gcfxd-xorg-devel=m.gmane.org-go0+a7rfsptAfugRpC6u6w@public.gmane.org Cc: xorg-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org On Thu, 28 Apr 2011 13:27:18 -0700 Jesse Barnes wrote: > I obviously failed to count the swap event structure size after adding > and removing fields a few times, and didn't even account for padding. The > end result is that clients today won't receive the sbc_lo field at all, > and so will likely stuff junk into that field on the client side (or > zero at best). > > This patchset fixes up the structure definitions, bumps the proto > levels, and adds server and client handling code for it all. It should > be forward and backward compatible, but as always review and testing > appreciated. > > I think the event_type checking on the client side still needs work; > the field is split now so I need to check the right one on old servers. > I'll also add swap support for the new requests in case people ever want > to run this stuff between big and little endian machines. Btw, I've been trying to test these fixes but I can't make the existing code break; I'm getting a nicely incrementing sbc count using the piglit event test (after adding some code to dump the swap event fields), so somehow the bits are getting through. I just don't know how yet... -- Jesse Barnes, Intel Open Source Technology Center _______________________________________________ xorg-devel-go0+a7rfsptAfugRpC6u6w@public.gmane.org: X.Org development Archives: http://lists.x.org/archives/xorg-devel Info: http://lists.x.org/mailman/listinfo/xorg-devel