[Bug 36753] New: Some textures now rendered as completely black after register allocator rewrite.

[Bug 36753] New: Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

           Summary: Some textures now rendered as completely black after
                    register allocator rewrite.
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: rankincj@googlemail.com


Running World of Warcraft on my M66GL (RV530), and some textures are now
rendered as completely black. However, my RV350 is unaffected.

git bisect says:

fe622bac0c1b5b9f2a9fcf9f35b51232a06bea42 is the first bad commit
commit fe622bac0c1b5b9f2a9fcf9f35b51232a06bea42
Author: Tom Stellard <tstellar@gmail.com>
Date:   Tue Jan 11 00:05:08 2011 -0800

    r300/compiler: Rewrite register allocator

    The new allocator uses ra and does swizzle packing.

    Also, a data structure (struct rc_variable) and associated functions have
    been added for generating UD and DU chains.

:040000 040000 545a13a6577705511d30b471d6901237e793679c
f27924a4a5a40bab284ea7c03facab6c69875fb9 M    src

The following error messages are written to the output log:

r300 FP: Compiler Error:
Rewrite of inst 10 failed Can't allocate source for Inst 13 src_type=1
new_index=2 new_mask=1
Using a dummy shader instead.
r300 FP: Compiler Error:
Rewrite of inst 14 failed Can't allocate source for Inst 17 src_type=1
new_index=2 new_mask=1
Using a dummy shader instead.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #1 from Tom Stellard <tstellar@gmail.com> 2011-05-01 17:22:17 PDT ---
Can you run the program with RADEON_DEBUG=fp and post the output.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #2 from Chris Rankin <rankincj@googlemail.com> 2011-05-02 06:04:46 PDT ---
Created an attachment (id=46250)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46250)
FP debug output

Strictly speaking, this output is from RADEON_DEBUG=nohiz,fp because HiZ is
also broken with M66GL chips at the moment.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #3 from Tom Stellard <tstellar@gmail.com> 2011-05-04 00:28:04 PDT ---
(In reply to comment #2)
> Created an attachment (id=46250)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46250)
> FP debug output
> 
> Strictly speaking, this output is from RADEON_DEBUG=nohiz,fp because HiZ is
> also broken with M66GL chips at the moment.

I'm working on a proper fix for this.  In the mean time, running with
RADEON_DEBUG=noopt should fix the problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #4 from Chris Rankin <rankincj@googlemail.com> 2011-05-05 13:14:55 PDT ---
(In reply to comment #3)
> In the mean time, running with RADEON_DEBUG=noopt should fix the problem.

Indeed it does, thanks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #5 from Tom Stellard <tstellar@gmail.com> 2011-05-15 22:01:41 PDT ---
Created an attachment (id=46753)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46753
 Review: https://bugs.freedesktop.org/review?bug=36753&attachment=46753

Verbose patch

The patch will give me some extra debug info.  Can you apply it and post the
output of RADEON_DEBUG=fp.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #6 from Chris Rankin <rankincj@googlemail.com> 2011-05-16 16:33:46 PDT ---
Created an attachment (id=46786)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46786)
Output of RADEON_DEBUG=nohiz,fp

(In reply to comment #5)
> The patch will give me some extra debug info.  Can you apply it and post the
> output of RADEON_DEBUG=fp.

As requested.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #7 from Tom Stellard <tstellar@gmail.com> 2011-05-17 00:59:25 PDT ---
Created an attachment (id=46792)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46792
 Review: https://bugs.freedesktop.org/review?bug=36753&attachment=46792

Possible Fix

Can you try this patch.  If it doesn't fix the issue, can you post the output
of RADEON_DEBUG=fp again.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

--- Comment #8 from Chris Rankin <rankincj@googlemail.com> 2011-05-17 10:14:40 PDT ---
Created an attachment (id=46833)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46833)
Output of RADEON_DEBUG=nohiz,fp

(In reply to comment #7)
> Can you try this patch?

That seems to have fixed it, thanks. I've attached the RADEON_DEBUG output
anyway, so that you can check that it did what you were expecting.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36753] Some textures now rendered as completely black after register allocator rewrite.

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36753

Tom Stellard <tstellar@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #9 from Tom Stellard <tstellar@gmail.com> 2011-05-17 19:18:57 PDT ---
Fixed in git by commit 217cd216eac65983004ca77a9e49dbfad1b720b6.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.