dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: bugzilla-daemon@freedesktop.org
To: dri-devel@lists.freedesktop.org
Subject: [Bug 37142] Too much vertex buffers uploads
Date: Thu, 12 May 2011 10:55:30 -0700 (PDT)	[thread overview]
Message-ID: <20110512175530.3341E13004E@annarchy.freedesktop.org> (raw)
In-Reply-To: <bug-37142-502@http.bugs.freedesktop.org/>

https://bugs.freedesktop.org/show_bug.cgi?id=37142

--- Comment #1 from Ian Romanick <idr@freedesktop.org> 2011-05-12 10:55:30 PDT ---
(In reply to comment #0)
> Created an attachment (id=46638)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46638)
> openarena + verbose vertex buffer upload logs
> 
> Test case : openarena + anholt benchmark + r600g
> 
> I added several fprintf debug trace to mesa code around Vertex buffer
> uploading.
> Basically, openarena render things using :
> glVertexPointeer()
> glLockArraysEXT()
> several glDrawElements()
> glUnlockArraysEXT()
> 
> It seems that each call to glDrawElements implies a reupload of the vertex
> buffers, even if it has not changed (as glLock/Unlock calls tell, at least for
> part of the buffer).

EXT_compiled_vertex_array is dead.  It has been dead for almost 10 years.  No
new applications should use it, and old applications that use it should be fast
enough on modern hardware.  I really don't think we should add any code to Mesa
to make this case fast.  We'd be better off submitting patches to openarena to
use VBOs instead.

> Another related bug (it seems) is in : cso_set_vertex_buffers() which does a
> test before calling : util_copy_vertex_buffers and pipe->set_vertex_buffers
> This test always return true, thus the 2 above functions are always called. The
> test is always true because it memcmp all pipe_vertex_buffer, which contains a
> 'buffer' pointer, which changes at each frame (see st_draw.c:349).
> 
> I'm trying to build a patch which fix the cso_set_vertex_buffers problem and
> then, taking advantage of glLock/Unlock calls to fix the upload issue.
> 
> What do you think ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

  parent reply	other threads:[~2011-05-12 17:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-12 15:11 [Bug 37142] New: Too much vertex buffers uploads bugzilla-daemon
2011-05-12 15:15 ` [Bug 37142] " bugzilla-daemon
2011-05-12 17:54 ` bugzilla-daemon
2011-05-12 17:55 ` bugzilla-daemon [this message]
2011-05-12 19:55 ` bugzilla-daemon
2011-05-12 20:19 ` bugzilla-daemon
2011-05-12 20:27 ` bugzilla-daemon
2011-05-13  7:11 ` bugzilla-daemon
2011-05-13 16:22 ` bugzilla-daemon
2011-05-17 12:33 ` bugzilla-daemon
2014-04-13 11:20 ` bugzilla-daemon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110512175530.3341E13004E@annarchy.freedesktop.org \
    --to=bugzilla-daemon@freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).