[Bug 36952] New: segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[Bug 36952] New: segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

           Summary: segfault in crackberg xscreensaver on ATI RS482 in
                    mesa git running kms & gallium
           Product: Mesa
           Version: git
          Platform: x86 (IA32)
        OS/Version: Linux (All)
            Status: NEW
          Severity: normal
          Priority: medium
         Component: Drivers/Gallium/r300
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: writemeanddie@hotmail.com


system 32 bit gentoo
video card ATI RS482 configured to share 128MB system RAM
kernel 2.6.38.4
xorg-server 1.10.1
mesa git commit 37058c3497850f452bdaf70a5dda07ee4840b6b9 May 4 2011
xf86-video-ati git commit 62a4cd180fe884dca24586d453395472516e6496 May 4, 2011
mesa compile flags: classic egl gallium llvm nptl openvg shared-dricore
video_cards_r300 video_cards_radeon
xscreensaver 5.12

When running the xscreensaver 'crackberg' on mesa from git the screen freezes
for 20-60 seconds (I think memory is filling up and swapping out RAM) and then
the program exits with a segfault.  The message in /var/log/kern.log is
kernel: crackberg[30926]: segfault at b5a30000 ip b653b2c1 sp bf943e30 error 4.
If I downgrade to mesa 7.10.2-r1 the screensaver works as expected.  If I run
with ums the screensaver works as expected.  Other screensavers are affected as
well, I can compile a list if necessary.

Any other logs or info that I can collect is no problem.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #1 from Iaroslav <pontostroy@gmail.com> 2011-05-08 08:35:00 PDT ---
Created an attachment (id=46449)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=46449)
backtrace

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #2 from Iaroslav <pontostroy@gmail.com> 2011-05-08 08:35:24 PDT ---
I have some problem, and i have  ATI RS482 too, but i think it was the fault
llvm, with out llvm or < 2.9 , all woks fine, with llvm > 2.8  openarena,
urbanterror and some xscreensaver segfault. see
https://bugs.freedesktop.org/show_bug.cgi?id=36738
I make backtrace with crackberg.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #3 from Alex Deucher <agd5f@yahoo.com> 2011-05-08 19:11:01 PDT ---
Can you bisect mesa?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #4 from dri tester <writemeanddie@hotmail.com> 2011-05-09 06:22:56 PDT ---
But if I downgrade to mesa 7.10.2, I am still using llvm 2.9 and the
crackberg screensaver works correctly, so that would point to mesa-git
being the problem for me.  I cannot compile mesa-git without llvm as the
build process halts and complains that r300 gallium requires llvm to
build.  There are three gentoo patches that get applied on top of the
mesa 7.10.2-r1 build, I haven't looked at what they do yet.

(In reply to comment #2)
> I have some problem, and i have  ATI RS482 too, but i think it was the fault
> llvm, with out llvm or < 2.9 , all woks fine, with llvm > 2.8  openarena,
> urbanterror and some xscreensaver segfault. see
> https://bugs.freedesktop.org/show_bug.cgi?id=36738
> I make backtrace with crackberg.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #5 from dri tester <writemeanddie@hotmail.com> 2011-05-09 06:28:19 PDT ---
I will try to bisect.  I have to figure out how to install mesa-git without the
ebuild (and without messing up my dependencies), or is there a way to pass
commit tags to 'emerge' or specify in the ebuild?  Either way once I figure
that out I will bisect mesa.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #6 from Chris Bandy <cbandy@jbandy.com> 2011-05-09 09:52:02 PDT ---
(In reply to comment #5)
> is there a way to pass commit tags to 'emerge' or specify in the ebuild?

The x11 overlay has live ebuilds. Use EGIT_COMMIT to specify a commit to
checkout.

http://devmanual.gentoo.org/eclass-reference/git-2.eclass/index.html

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #7 from Iaroslav <pontostroy@gmail.com> 2011-05-09 09:57:59 PDT ---
(In reply to comment #4)
> But if I downgrade to mesa 7.10.2, I am still using llvm 2.9 and the
> crackberg screensaver works correctly, so that would point to mesa-git
> being the problem for me.  I cannot compile mesa-git without llvm as the
> build process halts and complains that r300 gallium requires llvm to
> build.  There are three gentoo patches that get applied on top of the
> mesa 7.10.2-r1 build, I haven't looked at what they do yet.
> 
> (In reply to comment #2)
> > I have some problem, and i have  ATI RS482 too, but i think it was the fault
> > llvm, with out llvm or < 2.9 , all woks fine, with llvm > 2.8  openarena,
> > urbanterror and some xscreensaver segfault. see
> > https://bugs.freedesktop.org/show_bug.cgi?id=36738
> > I make backtrace with crackberg.

Can you run crackberg with gdb, and show backtrace? Or run openarena with
mesa-git+llvm-2.9.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #8 from dri tester <writemeanddie@hotmail.com> 2011-05-13 03:45:55 PDT ---
(In reply to comment #3)
> Can you bisect mesa?

Bisecting lead me to this commit:

b10bff11350014e1bb49b0ce18704fdd66e850c0 is the first bad commit
commit b10bff11350014e1bb49b0ce18704fdd66e850c0
Author: Marek Olšák <maraeo@gmail.com>
Date:   Sat Dec 25 14:39:07 2010 +0100

    r300g: increase the size of upload buffers

On the way here, some of the bisects that failed had varying behaviour.  All of
them had abysmal frame rates and the CPU% shot up to 100% on one CPU (only uses
50% prior to this commit).  Some continued to run, others locked up the x
server and required an Alt-SysRq-B to reboot.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #9 from Marek Olšák <maraeo@gmail.com> 2011-05-13 15:24:00 PDT ---
Created an attachment (id=46696)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46696
 Review: https://bugs.freedesktop.org/review?bug=36952&attachment=46696

possible fix

Could you try this patch?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #10 from dri tester <writemeanddie@hotmail.com> 2011-05-14 17:55:51 PDT ---
(In reply to comment #9)
> Created an attachment (id=46696)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46696
 Review: https://bugs.freedesktop.org/review?bug=36952&attachment=46696

> possible fix
> 
> Could you try this patch?

The patch applied to latest mesa-git allows crackberg to run at the expected
framerate with the expected cpu% for a few seconds (5-15 seconds), then it
segfaults.  The segfault might be caused by a different commit.  Would it be
worth bisecting again but applying the possible fix patch above each time
before compiling to see if I can find another bad commit?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #11 from Marek Olšák <maraeo@gmail.com> 2011-05-14 18:08:28 PDT ---
It would be better to experiment with the patch and try smaller buffer sizes.
Please let me know when you find a size which works.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #12 from dri tester <writemeanddie@hotmail.com> 2011-05-16 06:14:40 PDT ---
(In reply to comment #11)
> It would be better to experiment with the patch and try smaller buffer sizes.
> Please let me know when you find a size which works.

The current mesa-git value for the R300_MAX_DRAW_VBO_SIZE is 1024 * 1024 and
your patch dropped it down to 512 * 1024.  I tried with 64 * 1024 (which is the
value that worked before the commit that I bisected above) and crackberg works,
the animation is smooth and the cpu usage is 50% on one cpu, but it segfaults
after 13-18 seconds.  I really think there is another bug being uncovered here.
 I do not know which buffer size to recommend for R300_MAX_DRAW_VBO_SIZE, 512 *
1024 as per your attached patch worked as well as 64 * 1024.  I assume that the
value must be a power of 2, or are there some other values to test?  Should I
test the values between 64 and 512 for completeness?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #13 from dri tester <writemeanddie@hotmail.com> 2011-05-16 06:49:15 PDT ---
(In reply to comment #12)
> (In reply to comment #11)
> > It would be better to experiment with the patch and try smaller buffer sizes.
> > Please let me know when you find a size which works.
> 
> The current mesa-git value for the R300_MAX_DRAW_VBO_SIZE is 1024 * 1024 and
> your patch dropped it down to 512 * 1024.  I tried with 64 * 1024 (which is the
> value that worked before the commit that I bisected above) and crackberg works,
> the animation is smooth and the cpu usage is 50% on one cpu, but it segfaults
> after 13-18 seconds.  I really think there is another bug being uncovered here.
>  I do not know which buffer size to recommend for R300_MAX_DRAW_VBO_SIZE, 512 *
> 1024 as per your attached patch worked as well as 64 * 1024.  I assume that the
> value must be a power of 2, or are there some other values to test?  Should I
> test the values between 64 and 512 for completeness?

Disregard my last comment above, I was totally incorrect.  A value for
R300_MAX_DRAW_VBO_SIZE of 32 * 1024 fixed crackberg completely for me.  I will
attach the working patch as 0003-r300g-allocate-smaller-upload-buffers.patch. 
Thanks Marek.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

dri tester <writemeanddie@hotmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46696|0                           |1
        is obsolete|                            |

--- Comment #14 from dri tester <writemeanddie@hotmail.com> 2011-05-16 06:52:09 PDT ---
Created an attachment (id=46763)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46763
 Review: https://bugs.freedesktop.org/review?bug=36952&attachment=46763

fix for crackberg performance and segfaulting on rs482

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #15 from dri tester <writemeanddie@hotmail.com> 2011-05-16 06:56:39 PDT ---
(In reply to comment #14)
> Created an attachment (id=46763)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46763
 Review: https://bugs.freedesktop.org/review?bug=36952&attachment=46763

> fix for crackberg performance and segfaulting on rs482

Hmmmm, the lateset patch with a value of 32 * 1024 fixes crackberg but now
antmaze gives me:
radeon: The kernel rejected CS, see dmesg for more information.

and dmesg says:
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
radeon 0000:01:05.0: (PW 2) Vertex array 0 need 8436 dwords have 8192 dwords
[drm:radeon_cs_ioctl] *ERROR* Invalid command stream !
antmaze[13259]: segfault at 4 ip b5b57000 sp bfd14fcc error 6

I will play with the values some more.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #16 from Marek Olšák <maraeo@gmail.com> 2011-05-16 17:19:46 PDT ---
It's possible the bisection went wrong and the upload buffer size has nothing
to do with this issue.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 383 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

--- Comment #17 from Tomasz P. <son_of_the_osiris@interia.pl> ---
I just instaled xscreensaver and run crackberg on rv350 / radeon 9600
agp.Normal memory usage nothing special.No warnings in logs. Animation works
without any artefacts or screen flashing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1235 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36952] segfault in crackberg xscreensaver on ATI RS482 in mesa git running kms & gallium

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 424 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=36952

Tomasz P. <son_of_the_osiris@interia.pl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1267 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel