Re: + drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree

Re: + drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree

[Uwe Kleine-König]

Hello,

[added some people involved in the thread
http://thread.gmane.org/gmane.linux.ports.ppc.embedded/41996 to Cc:]

On Wed, May 18, 2011 at 02:57:36PM -0700, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      drivers/base/platform.c: don't mark platform_device_register_resndata() as __init_or_module
> has been added to the -mm tree.  Its filename is
>      drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/SubmitChecklist when testing your code ***
> 
> See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
> out what to do about this
> 
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> 
> ------------------------------------------------------
> Subject: drivers/base/platform.c: don't mark platform_device_register_resndata() as __init_or_module
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> This reverts 737a3bb9416ce2a7c7a4 ("Driver core: move platform device
> creation helpers to .init.text (if MODULE=n)").  That patch assumed that
> platform_device_register_resndata() is only ever called from __init code
> but that isn't true in the case ioctl->drm_ioctl->radeon_cp_init().
> 
> Addresses https://bugzilla.kernel.org/show_bug.cgi?id=35192
I'm not sure that the things that radeon_cp_init does are sane. Maybe
add a comment that it is the only known stopper to make
platform_device_register_resndata __init_or_module and a similar comment
to platform_device_register_resndata itself?

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Re: + drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree

[Andrew Morton]

On Thu, 19 May 2011 08:21:36 +0200 Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:

> I'm not sure that the things that radeon_cp_init does are sane.

Some more details here might help someone fix it.

> Maybe
> add a comment that it is the only known stopper to make
> platform_device_register_resndata __init_or_module and a similar comment
> to platform_device_register_resndata itself?

Send patch :)

_______________________________________________
stable mailing list
stable@linux.kernel.org
http://linux.kernel.org/mailman/listinfo/stable