From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: + drivers-base-platformc-dont-mark-platform_device_register_resndata-as-__init_or_module.patch added to -mm tree Date: Thu, 19 May 2011 08:21:36 +0200 Message-ID: <20110519062136.GA8297@pengutronix.de> References: <201105182157.p4ILvaJn026575@imap1.linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by gabe.freedesktop.org (Postfix) with ESMTP id EC8819F3A1 for ; Wed, 18 May 2011 23:22:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: <201105182157.p4ILvaJn026575@imap1.linux-foundation.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: akpm@linux-foundation.org Cc: mm-commits@vger.kernel.org, Greg KH , Michel =?iso-8859-1?Q?D=E4nzer?= , gregkh@suse.de, dri-devel@lists.freedesktop.org, blueness@gentoo.org, Gabriel Paubert , stable@kernel.org List-Id: dri-devel@lists.freedesktop.org Hello, [added some people involved in the thread http://thread.gmane.org/gmane.linux.ports.ppc.embedded/41996 to Cc:] On Wed, May 18, 2011 at 02:57:36PM -0700, akpm@linux-foundation.org wrote: > = > The patch titled > drivers/base/platform.c: don't mark platform_device_register_resndat= a() as __init_or_module > has been added to the -mm tree. Its filename is > drivers-base-platformc-dont-mark-platform_device_register_resndata-a= s-__init_or_module.patch > = > Before you just go and hit "reply", please: > a) Consider who else should be cc'ed > b) Prefer to cc a suitable mailing list as well > c) Ideally: find the original patch on the mailing list and do a > reply-to-all to that, adding suitable additional cc's > = > *** Remember to use Documentation/SubmitChecklist when testing your code = *** > = > See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find > out what to do about this > = > The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmot= m/ > = > ------------------------------------------------------ > Subject: drivers/base/platform.c: don't mark platform_device_register_res= ndata() as __init_or_module > From: Andrew Morton > = > This reverts 737a3bb9416ce2a7c7a4 ("Driver core: move platform device > creation helpers to .init.text (if MODULE=3Dn)"). That patch assumed that > platform_device_register_resndata() is only ever called from __init code > but that isn't true in the case ioctl->drm_ioctl->radeon_cp_init(). > = > Addresses https://bugzilla.kernel.org/show_bug.cgi?id=3D35192 I'm not sure that the things that radeon_cp_init does are sane. Maybe add a comment that it is the only known stopper to make platform_device_register_resndata __init_or_module and a similar comment to platform_device_register_resndata itself? Best regards Uwe -- = Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | http://www.pengutronix.de/ |