From mboxrd@z Thu Jan  1 00:00:00 1970
From: Nicolas Kaiser <nikai@nikai.net>
Subject: Re: [PATCH] savage: remove unecessary if statement
Date: Mon, 6 Jun 2011 12:53:16 +0200
Message-ID: <20110606125316.312fad32@absol.kitzblitz>
References: <1307320332-31429-1-git-send-email-Gregory.Dietsche@cuw.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1307320332-31429-1-git-send-email-Gregory.Dietsche@cuw.edu>
Sender: linux-kernel-owner@vger.kernel.org
To: Dave Airlie <airlied@linux.ie>
Cc: Greg Dietsche <Gregory.Dietsche@cuw.edu>, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

* Greg Dietsche <Gregory.Dietsche@cuw.edu>:
> the code always returns ret regardless, so if(ret) check is unecessary.
/unecessary/unnecessary/

> 
> Signed-off-by: Greg Dietsche <Gregory.Dietsche@cuw.edu>
Reviewed-by: Nicolas Kaiser <nikai@nikai.net>

Best regards,
Nicolas Kaiser
> ---
>  drivers/gpu/drm/savage/savage_bci.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/savage/savage_bci.c b/drivers/gpu/drm/savage/savage_bci.c
> index bf5f83e..cb1ee4e 100644
> --- a/drivers/gpu/drm/savage/savage_bci.c
> +++ b/drivers/gpu/drm/savage/savage_bci.c
> @@ -647,9 +647,6 @@ int savage_driver_firstopen(struct drm_device *dev)
>  	ret = drm_addmap(dev, aperture_base, SAVAGE_APERTURE_SIZE,
>  			 _DRM_FRAME_BUFFER, _DRM_WRITE_COMBINING,
>  			 &dev_priv->aperture);
> -	if (ret)
> -		return ret;
> -
>  	return ret;
>  }
>