From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Cox Subject: Re: [PATCH 2/4] drm: add an fb creation ioctl that takes a pixel format Date: Thu, 9 Jun 2011 09:21:28 +0100 Message-ID: <20110609092128.323b8a05@lxorguk.ukuu.org.uk> References: <1307477262-8242-1-git-send-email-jbarnes@virtuousgeek.org> <1307477262-8242-3-git-send-email-jbarnes@virtuousgeek.org> <1307592359.14014.5.camel@clockmaker-el6> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from www.etchedpixels.co.uk (earthlight.etchedpixels.co.uk [81.2.110.250]) by gabe.freedesktop.org (Postfix) with ESMTP id 83A239E9BF for ; Thu, 9 Jun 2011 01:19:24 -0700 (PDT) In-Reply-To: <1307592359.14014.5.camel@clockmaker-el6> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, 09 Jun 2011 14:05:59 +1000 Dave Airlie wrote: > On Tue, 2011-06-07 at 13:07 -0700, Jesse Barnes wrote: > > To properly support the various plane formats supported by different > > hardware, the kernel must know the pixel format of a framebuffer object. > > So add a new ioctl taking a format argument corresponding to a fourcc > > name from videodev2.h. > > I'd rather we don't directly tie things like that, either create a > fourcc header that isn't V4L2 or DRM related and use that or generate > two headers one with DRM_ and one with V4L2 prefixes. Mainly so we can > keep the DRM interface in some way OS agnostic. It *is* OS agnostic (it started on the Amiga) You also don't need a headwer with a complete list of fourcc names in it, that is the half the point of FourCC. Alan