From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] drm/i915: add check for valid init_clock_gating-pointer
Date: Wed, 15 Jun 2011 15:30:00 -0700
Message-ID: <20110615153000.00438750@jbarnes-desktop>
References: <1308176679-13766-1-git-send-email-w.sang@pengutronix.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com
	[67.222.54.6])
	by gabe.freedesktop.org (Postfix) with SMTP id 988B99F6D5
	for <dri-devel@lists.freedesktop.org>;
	Wed, 15 Jun 2011 15:30:11 -0700 (PDT)
In-Reply-To: <1308176679-13766-1-git-send-email-w.sang@pengutronix.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Wolfram Sang <w.sang@pengutronix.de>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Thu, 16 Jun 2011 00:24:39 +0200
Wolfram Sang <w.sang@pengutronix.de> wrote:

> Commit 6067aa (drm/i915: split clock gating init into per-chipset
> functions) unconditionally calls the newly created
> init_clock_gating-pointer. There is one case, however, where it does
> not get set:
> 
> if (HAS_PCH_SPLIT(dev)) {
> 	...
> 	} else
> 		dev_priv->display.update_wm = NULL;
> }

We'll only hit this path on non-existent hardware.  Since a clock
gating routine is required I'd rather just see the panic and add a new
routine at that time (i.e. what we normally do during bringup).

-- 
Jesse Barnes, Intel Open Source Technology Center