From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Date: Sat, 2 Jul 2011 11:00:07 -0700 Message-ID: <20110702110007.4393473e@jbarnes-desktop> References: <013811$hje8d@fmsmga002.fm.intel.com> <1308591371-23207-1-git-send-email-w.sang@pengutronix.de> <20110620103854.4c6c7dba@jbarnes-desktop> <20110702155553.GA18188@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id D946C9E744 for ; Sat, 2 Jul 2011 11:00:20 -0700 (PDT) In-Reply-To: <20110702155553.GA18188@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Wolfram Sang Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Sat, 2 Jul 2011 17:55:53 +0200 Wolfram Sang wrote: > On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote: > > On Mon, 20 Jun 2011 19:36:11 +0200 > > Wolfram Sang wrote: > > > > > Commit 6067aa (drm/i915: split clock gating init into per-chipset > > > functions) introduces an init_clock_gating-pointer. There is one case, > > > however, where it does not get set, so that caused an OOPS. Change the > > > code to return -ENODEV in this case and propagate it to the upper > > > layers. > > > > > > Signed-off-by: Wolfram Sang > > > Cc: Jesse Barnes > > > Cc: Chris Wilson > > > --- > > > > Looks good, thanks Wolfram. > > > > Reviewed-by: Jesse Barnes > > Just wondering: I don't see it in linux-next or the i915-branches I am aware > of. Forgotten or intentional? Bounce it over to Keith with the reviewed-by and he'll pick it up. -- Jesse Barnes, Intel Open Source Technology Center