From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfram Sang Subject: Re: [PATCH V2] drm/i915: gracefully bail out when init_clock_gating-pointer is not set Date: Sat, 2 Jul 2011 17:55:53 +0200 Message-ID: <20110702155553.GA18188@pengutronix.de> References: <013811$hje8d@fmsmga002.fm.intel.com> <1308591371-23207-1-git-send-email-w.sang@pengutronix.de> <20110620103854.4c6c7dba@jbarnes-desktop> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1741470492==" Return-path: Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [92.198.50.35]) by gabe.freedesktop.org (Postfix) with ESMTP id 316DC9E73F for ; Sat, 2 Jul 2011 08:55:55 -0700 (PDT) In-Reply-To: <20110620103854.4c6c7dba@jbarnes-desktop> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesse Barnes Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1741470492== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7AUc2qLy4jB3hD7Z" Content-Disposition: inline --7AUc2qLy4jB3hD7Z Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jun 20, 2011 at 10:38:54AM -0700, Jesse Barnes wrote: > On Mon, 20 Jun 2011 19:36:11 +0200 > Wolfram Sang wrote: >=20 > > Commit 6067aa (drm/i915: split clock gating init into per-chipset > > functions) introduces an init_clock_gating-pointer. There is one case, > > however, where it does not get set, so that caused an OOPS. Change the > > code to return -ENODEV in this case and propagate it to the upper > > layers. > >=20 > > Signed-off-by: Wolfram Sang > > Cc: Jesse Barnes > > Cc: Chris Wilson > > --- >=20 > Looks good, thanks Wolfram. >=20 > Reviewed-by: Jesse Barnes Just wondering: I don't see it in linux-next or the i915-branches I am aware of. Forgotten or intentional? --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --7AUc2qLy4jB3hD7Z Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iEYEARECAAYFAk4PP4kACgkQD27XaX1/VRtkJwCgotChetb+34vVKBUh0UmdLXC+ tGIAn3gOnpVftdQwj2E/SLJMmAvrT2WI =HOFr -----END PGP SIGNATURE----- --7AUc2qLy4jB3hD7Z-- --===============1741470492== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============1741470492==--