From mboxrd@z Thu Jan 1 00:00:00 1970 From: bugzilla-daemon@freedesktop.org Subject: [Bug 34495] Selecting objects in Blender 2.56 slow with gallium r600 driver Date: Sat, 2 Jul 2011 10:32:49 -0700 (PDT) Message-ID: <20110702173249.8267A13004D@annarchy.freedesktop.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from annarchy.freedesktop.org (annarchy.freedesktop.org [131.252.210.176]) by gabe.freedesktop.org (Postfix) with ESMTP id AF7FA9E759 for ; Sat, 2 Jul 2011 10:32:49 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org https://bugs.freedesktop.org/show_bug.cgi?id=34495 --- Comment #35 from Micael Dias 2011-07-02 10:32:48 PDT --- (In reply to comment #32) > Created an attachment (id=48680) View: https://bugs.freedesktop.org/attachment.cgi?id=48680 Review: https://bugs.freedesktop.org/review?bug=34495&attachment=48680 > crash fix > > Here's a patch fixing (hopefully) the crash reported in comment #22 > > It add some logic to r600g query handling, to avoid unnecessary flushes and > infinite loop (though the crash is less easy to reproduce with git master > because commit 61c976c3ccc815aaf0128eea835aee9667cd8bbe reduces flush count) Looks good to me. There's just a typo in the comment you added r600_context_queries_resume(), should be "doesn't need" instead of "does need". I think you should send it to the list :) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug.