From: Frank van Maarseveen <frankvm@frankvm.com>
To: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: 2.6.39.3 nouveau_gart_manager_new() leaks memory (FIX)
Date: Thu, 4 Aug 2011 12:39:48 +0200 [thread overview]
Message-ID: <20110804103948.GA12474@janus> (raw)
In-Reply-To: <20110728100753.GA16736@janus>
On Thu, Jul 28, 2011 at 12:07:53PM +0200, Frank van Maarseveen wrote:
> /proc/slabinfo shows an anomaly on a 2.6.39.3 x86_64 system. After
> running F14 + kde4 for a while it shows high kmalloc-192 numbers:
>
> # name <active_objs> <num_objs> <objsize> <objperslab> <pagesperslab>...
> kmalloc-192 735694 735723 264 31 2 : tunables 0 0 0 : slabdata 23733 23733 0
>
> Digging in /sys/kernel/slab/kmalloc-192/alloc_calls one line stands out:
>
> 701960 nouveau_gart_manager_new+0x5d/0xf0 age=24/7405655/87972315 pid=1-4920 cpus=0-3
>
> There are 709907 allocations total and according to
> /sys/kernel/slab/kmalloc-192/free_calls there are 52245 free
> calls total.
This seems to fix it:
diff -Nurp a/drivers/gpu/drm/nouveau/nouveau_mem.c b/drivers/gpu/drm/nouveau/nouveau_mem.c
--- a/drivers/gpu/drm/nouveau/nouveau_mem.c 2011-05-19 06:06:34.000000000 +0200
+++ b/drivers/gpu/drm/nouveau/nouveau_mem.c 2011-08-03 10:58:22.919205352 +0200
@@ -848,6 +848,7 @@ nouveau_gart_manager_del(struct ttm_mem_
nouveau_vm_unmap(&node->tmp_vma);
nouveau_vm_put(&node->tmp_vma);
}
+ kfree(node);
mem->mm_node = NULL;
}
--
Frank
prev parent reply other threads:[~2011-08-04 10:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-28 10:07 2.6.39.3 nouveau_gart_manager_new() leaks memory Frank van Maarseveen
2011-08-04 10:39 ` Frank van Maarseveen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110804103948.GA12474@janus \
--to=frankvm@frankvm.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox