From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] Fix wrong initializer for "locked" variable Date: Thu, 25 Aug 2011 09:22:30 -0700 Message-ID: <20110825092230.57354893@jbarnes-desktop> References: <201108251537.45999.thomas.jarosch@intra2net.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id BB2CEA0A48 for ; Thu, 25 Aug 2011 09:22:37 -0700 (PDT) In-Reply-To: <201108251537.45999.thomas.jarosch@intra2net.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Thomas Jarosch Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, 25 Aug 2011 15:37:45 +0200 Thomas Jarosch wrote: > Otherwise it just contains random memory. > > Issue detected by cppcheck. > > Signed-off-by: Thomas Jarosch > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c > index ee1d701..f6da4e4 100644 > --- a/drivers/gpu/drm/i915/intel_display.c > +++ b/drivers/gpu/drm/i915/intel_display.c > @@ -878,7 +878,7 @@ static void assert_panel_unlocked(struct drm_i915_private *dev_priv, > int pp_reg, lvds_reg; > u32 val; > enum pipe panel_pipe = PIPE_A; > - bool locked = locked; > + bool locked = true; > > if (HAS_PCH_SPLIT(dev_priv->dev)) { > pp_reg = PCH_PP_CONTROL; Hah yeah that's a good one, thanks for the fix. Reviewed-by: Jesse Barnes -- Jesse Barnes, Intel Open Source Technology Center