From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH 09/21] drm/i915: Delay DP i2c initialization until panel power timings are computed Date: Fri, 30 Sep 2011 19:25:47 +0200 Message-ID: <20110930172547.GI2859@phenom.ffwll.local> References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-10-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1317344993-24945-10-git-send-email-keithp@keithp.com> Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Sep 29, 2011 at 06:09:41PM -0700, Keith Packard wrote: > On eDP, DDC requires panel power, but turning that on uses the panel > power sequencing timing values fetch from the DPCD data. > > Signed-off-by: Keith Packard Can't really check more than what the patch does what it claims to do, so a weak: Reviewed-by: Daniel Vetter And a small question from the clueless: With your patch intel_dp_i2c_auch_ch checks whether panel or vdd is on, but I don't see where we turn that on and the drm dp i2c core seems to do a few transactions on setup time. Should we splatter a vdd_on/off around the i2c_init or is the panel guaranteed to have power at init time? -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48