From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 02/21] drm/i915: Shut down PCH interrupts during irq_uninstall Date: Fri, 30 Sep 2011 19:56:14 +0200 Message-ID: <20110930175614.GM2859@phenom.ffwll.local> References: <20110923085243.6e4b7b4c@jbarnes-x220> <1317344993-24945-1-git-send-email-keithp@keithp.com> <1317344993-24945-3-git-send-email-keithp@keithp.com> <20110930162048.GB2859@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Keith Packard Cc: Daniel Vetter , Dave Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, Sep 30, 2011 at 10:44:22AM -0700, Keith Packard wrote: > On Fri, 30 Sep 2011 18:20:48 +0200, Daniel Vetter wrote: > > > Shouldn't we mask/ack south DE irqs before before we mask DE irqs to avoid > > races, i.e. move this new code up? > > I don't know. What about the GT interrupts? I just stuck stuff at the > bottom, figuring it would do the least harm... Thinking this through again I don't see the race anymore. I've forgotten that masking things in IMR also prevents stuff from showing up in IIR and hence a SDE irq after clearing DE irqs can't leave garbage behind in DEIIR. So no need to clear things in the order the irqs propagate, i.e. SDE->DE->GT. For the patch: Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48