From: Daniel Vetter <daniel@ffwll.ch>
To: Ilija Hadzic <ihadzic@research.bell-labs.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: drm/fb_helper: prevent some troubles waiting to happen
Date: Wed, 26 Oct 2011 09:41:24 +0200 [thread overview]
Message-ID: <20111026074124.GA2889@phenom.ffwll.local> (raw)
In-Reply-To: <1319594239-2506-1-git-send-email-ihadzic@research.bell-labs.com>
On Tue, Oct 25, 2011 at 09:57:17PM -0400, Ilija Hadzic wrote:
> The following two patches address potential problems that I
> called "troubles waiting to happen" in this note
> http://lists.freedesktop.org/archives/dri-devel/2011-October/015412.html
>
> I didn't hear anyone take on my question, so I figured I would just send
> the patches. I tested the patches on a variety of AMD cards that I have.
> I don't have other GPUs handy.
I've quickly checked current callsites of drm_fb_helper_init and I think
you can just kill the two arguments crtc_count and max_conn_count. All
drivers pass in the actual crtc count for the first and some midly bogus
constant for the latter.
i915 and radeon also use that constant to attach some struct drm_connector
* pointers to the end of their crtc, which looks rather unused. You might
want to kill that, too.
-Daniel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-26 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-26 1:57 drm/fb_helper: prevent some troubles waiting to happen Ilija Hadzic
2011-10-26 1:57 ` [PATCH 1/2] drm/fb_helper: make sure crtc_count is consistent Ilija Hadzic
2011-10-26 1:57 ` [PATCH 2/2] drm/fb_helper: honor the limit on number of connectors per crtc Ilija Hadzic
2011-10-26 7:41 ` Daniel Vetter [this message]
2011-10-26 16:17 ` drm/fb_helper: prevent some troubles waiting to happen Ilija Hadzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111026074124.GA2889@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=ihadzic@research.bell-labs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox