dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Joonyoung Shim <jy0922.shim@samsung.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 01/11] drm: add plane support
Date: Thu, 27 Oct 2011 08:31:00 -0700	[thread overview]
Message-ID: <20111027083100.4983f5f9@jbarnes-desktop> (raw)
In-Reply-To: <4EA79D37.4080007@samsung.com>


[-- Attachment #1.1: Type: text/plain, Size: 1637 bytes --]

On Wed, 26 Oct 2011 14:40:07 +0900
Joonyoung Shim <jy0922.shim@samsung.com> wrote:

> 10/25/2011 06:46 PM, Jesse Barnes 쓴 글:
> 
> [snip]
> > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
> > index 8020798..d7f03aa 100644
> > --- a/include/drm/drm_crtc.h
> > +++ b/include/drm/drm_crtc.h
> > @@ -44,6 +44,7 @@ struct drm_framebuffer;
> >   #define DRM_MODE_OBJECT_PROPERTY 0xb0b0b0b0
> >   #define DRM_MODE_OBJECT_FB 0xfbfbfbfb
> >   #define DRM_MODE_OBJECT_BLOB 0xbbbbbbbb
> > +#define DRM_MODE_OBJECT_PLANE 0xeeeeeeee
> >
> >   struct drm_mode_object {
> >   	uint32_t id;
> > @@ -278,6 +279,7 @@ struct drm_crtc;
> >   struct drm_connector;
> >   struct drm_encoder;
> >   struct drm_pending_vblank_event;
> > +struct drm_plane;
> >
> >   /**
> >    * drm_crtc_funcs - control CRTCs for a given device
> > @@ -536,6 +538,58 @@ struct drm_connector {
> >   };
> >
> >   /**
> > + * drm_plane_funcs - driver plane control functions
> > + * @update_plane: update the plane configuration
> > + */
> > +struct drm_plane_funcs {
> > +	int (*update_plane)(struct drm_plane *plane,
> > +			    struct drm_crtc *crtc, struct drm_framebuffer *fb,
> > +			    int crtc_x, int crtc_y,
> > +			    unsigned int crtc_w, unsigned int crtc_h,
> > +			    uint32_t src_x, uint32_t src_y,
> > +			    uint32_t src_w, uint32_t src_h);
> > +	int (*disable_plane)(struct drm_plane *plane);
> > +};
> 
> How about add destroy() function and call it in
> drm_mode_config_cleanup()?

Oh good idea; destroy will be needed for hot plug.

-- 
Jesse Barnes, Intel Open Source Technology Center

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2011-10-27 15:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-25  9:46 DRM planes and new fb creation ioctl Jesse Barnes
2011-10-25  9:46 ` [PATCH 01/11] drm: add plane support Jesse Barnes
2011-10-25 10:53   ` Joonyoung Shim
2011-10-25 11:18     ` Jesse Barnes
2011-10-26  0:19       ` Joonyoung Shim
2011-10-25 11:58   ` Daniel Vetter
2011-10-25 12:26     ` Jesse Barnes
2011-10-25 13:26     ` Alan Cox
2011-10-25 13:32       ` Jesse Barnes
2011-10-25 13:42       ` Daniel Vetter
2011-10-25 14:09   ` Jesse Barnes
2011-10-25 16:43     ` Rob Clark
2011-10-25 19:41       ` Daniel Vetter
2011-10-25 20:14         ` Rob Clark
2011-10-26  5:40   ` Joonyoung Shim
2011-10-27 15:31     ` Jesse Barnes [this message]
2011-10-25  9:46 ` [PATCH 02/11] drm: add an fb creation ioctl that takes a pixel format Jesse Barnes
2011-10-25  9:46 ` [PATCH 03/11] drm/i915: rename existing overlay support to "legacy" Jesse Barnes
2011-10-25  9:46 ` [PATCH 04/11] drm/i915: add SNB video sprite support Jesse Barnes
2011-10-25  9:47 ` [PATCH 05/11] drm/i915: move pin & fence for plane past potential error paths Jesse Barnes
2011-10-25  9:47 ` [PATCH 06/11] drm/i915: plane teardown fixes Jesse Barnes
2011-10-25  9:47 ` [PATCH 07/11] drm/i915: enable new overlay code on IVB too Jesse Barnes
2011-10-25  9:47 ` [PATCH 08/11] drm/i915: overlay watermark hack Jesse Barnes
2011-10-25  9:47 ` [PATCH 09/11] drm/i915: fix overlay fb object handling Jesse Barnes
2011-10-25  9:47 ` [PATCH 10/11] drm/i915: clamp sprite to viewable area Jesse Barnes
2011-10-25  9:47 ` [PATCH 11/11] drm/i915: add sprite scaling support Jesse Barnes
2011-10-25 10:47 ` DRM planes and new fb creation ioctl Joonyoung Shim
2011-10-25 11:13   ` Jesse Barnes
2011-10-26  1:04     ` Joonyoung Shim
2011-10-25 11:20 ` Jesse Barnes
2011-10-25 11:22 ` [PATCH] drm/i915: add SNB video sprite support Jesse Barnes
2011-10-25 11:30   ` Jesse Barnes
2011-11-01 14:11   ` Lan, Hai
2011-11-03 18:44     ` [Intel-gfx] " Jesse Barnes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111027083100.4983f5f9@jbarnes-desktop \
    --to=jbarnes@virtuousgeek.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jy0922.shim@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox