From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/23] drm/via: use drm_mm instead of drm_sman Date: Thu, 27 Oct 2011 23:00:09 +0200 Message-ID: <20111027210009.GA4876@phenom.ffwll.local> References: <1319713670-7475-1-git-send-email-daniel.vetter@ffwll.ch> <1319713670-7475-9-git-send-email-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EC429E8B3 for ; Thu, 27 Oct 2011 13:59:51 -0700 (PDT) Received: by wwe32 with SMTP id 32so1489746wwe.0 for ; Thu, 27 Oct 2011 13:59:50 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1319713670-7475-9-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: dri-devel@lists.freedesktop.org Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org On Thu, Oct 27, 2011 at 01:07:35PM +0200, Daniel Vetter wrote: > Now that we are again in proper control of owner_list, we need to > properly list_del it on free. > > Signed-off-by: Daniel Vetter Chris Wilson rightly complained that this doesn't explain the list_del magic going on. New commit msg reads: To make the transition in a piece-wise and bisectable way possible, I've hijacked the ->owner_list from drm_sman. While transitioning, the list_add was done by the driver, while the list_del was still done by the dying sman code. Now that we are in full control of ->owner_list, do the list_del ourselves. He also noted the superflous additions of INIT_LIST_HEAD and the stale comment about spinlock locking in the idr allocation (protected by dev->struct_mutex) that I've copied over. All fixed up and pushed out for the moment to my fdo repo: http://cgit.freedesktop.org/~danvet/drm/log/?h=kill-with-fire Cheers, Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48