From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH 09/23] drm/sis: use drm_mm instead of drm_sman
Date: Sat, 29 Oct 2011 02:25:11 +0200
Message-ID: <20111029002510.GE2919@phenom.ffwll.local>
References: <1319713670-7475-1-git-send-email-daniel.vetter@ffwll.ch>
	<1319713670-7475-10-git-send-email-daniel.vetter@ffwll.ch>
	<CAArsGaZXW41HAzqDRuJSYayHYA4pcU5dzCLGfoU8K-r_Dafm8g@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-fx0-f49.google.com (mail-fx0-f49.google.com
	[209.85.161.49])
	by gabe.freedesktop.org (Postfix) with ESMTP id C51679E7FA
	for <dri-devel@lists.freedesktop.org>;
	Fri, 28 Oct 2011 17:24:17 -0700 (PDT)
Received: by faaf16 with SMTP id f16so5527320faa.36
	for <dri-devel@lists.freedesktop.org>;
	Fri, 28 Oct 2011 17:24:17 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAArsGaZXW41HAzqDRuJSYayHYA4pcU5dzCLGfoU8K-r_Dafm8g@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Tormod Volden <lists.tormod@gmail.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Sat, Oct 29, 2011 at 12:47:18AM +0200, Tormod Volden wrote:
> On Thu, Oct 27, 2011 at 1:07 PM, Daniel Vetter <daniel.vetter@ffwll.ch> w=
rote:
> ...
> > @@ -139,13 +99,35 @@ static int sis_drm_alloc(struct drm_device *dev, s=
truct drm_file *file,
> ...
> > +#if defined(CONFIG_FB_SIS) || defined(CONFIG_FB_SIS_MODULE)
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 item->req.size =3D mem->size;
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 sis_malloc(&item->req);
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (item->req.size =3D=3D 0)
> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 retval =3D -ENOMEN;
> =

> ENOMEN is omen, I guess this was not compile tested with either CONFIG?

Oh gosh, this is embarassing ;-) I've indeed fumbled this and forgotten to
check that config option. Smashed your patch on top of mine. btw, do you
have some actual hw to test this on, or have you just checked out of
curiosity?

Thanks, Daniel
-- =

Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48