From: Daniel Vetter <daniel@ffwll.ch>
To: Marcin Slusarz <marcin.slusarz@gmail.com>
Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: serialize access to list of debugfs files
Date: Mon, 31 Oct 2011 22:00:04 +0100 [thread overview]
Message-ID: <20111031210004.GB30108@phenom.ffwll.local> (raw)
In-Reply-To: <20111031173357.GA28581@joi.lan>
On Mon, Oct 31, 2011 at 06:33:57PM +0100, Marcin Slusarz wrote:
> Nouveau, when configured with debugfs, creates debugfs files for every
> channel, so structure holding list of files needs to be protected from
> simultaneous changes by multiple threads.
>
> Without this patch it's possible to hit kernel oops in
> drm_debugfs_remove_files just by running a couple of xterms with
> looped glxinfo.
>
> Signed-off-by: Marcin Slusarz <marcin.slusarz@gmail.com>
And v2 also includes a nice comment in the header explaining the locking.
Awesome!
Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2011-10-31 21:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-30 22:04 [PATCH] drm: serialize access to debugs_nodes.list Marcin Slusarz
2011-10-31 8:06 ` Daniel Vetter
2011-10-31 17:00 ` Marcin Slusarz
2011-10-31 17:33 ` [PATCH] drm: serialize access to list of debugfs files Marcin Slusarz
2011-10-31 21:00 ` Daniel Vetter [this message]
2011-11-09 21:20 ` Marcin Slusarz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111031210004.GB30108@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=marcin.slusarz@gmail.com \
--cc=nouveau@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox