Re: [PATCH 1/5] drm: add plane support

[Daniel Vetter <daniel@ffwll.ch>]

On Thu, Nov 03, 2011 at 03:48:52PM -0700, Jesse Barnes wrote:
> On Thu, 3 Nov 2011 11:21:18 -0700
> Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> 
> > On Wed, 2 Nov 2011 15:33:04 -0700
> > Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > 
> > > On Wed,  2 Nov 2011 13:03:19 -0700
> > > Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > > 
> > > > Planes are a bit like half-CRTCs.  They have a location and fb, but
> > > > don't drive outputs directly.  Add support for handling them to the core
> > > > KMS code.
> > > 
> > > Accidentally left out the ->destroy hook in this one.  The drm-overlays
> > > branch at git://people.freedesktop.org/~jbarnes/linux has a fixed
> > > version, along with a couple of fixes for issues Chris and Dan pointed
> > > out.
> > 
> > Below is the updated patch with ->destroy in case this series passes
> > muster and Dave is ready to apply.
> 
> ...and now fixed to include a disable call if an active fb is destroyed
> while being used in a plane.
> 
> -- 
> Jesse Barnes, Intel Open Source Technology Center
> 
> From 94b16917fdd846d54bc8a23765201e32ceda43bf Mon Sep 17 00:00:00 2001
> From: Jesse Barnes <jbarnes@virtuousgeek.org>
> Date: Thu, 21 Apr 2011 16:58:37 -0700
> Subject: [PATCH 1/5] drm: add plane support
> 
> Planes are a bit like half-CRTCs.  They have a location and fb, but
> don't drive outputs directly.  Add support for handling them to the core
> KMS code.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Ok, with the drm_framebuffer_cleanup fixed up, this looks code. I've also
played around a bit with the legacy i8xx overlay, and the existing code
would nicely fit into ->update_plane and ->disable_plane.

Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
-- 
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48