From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH 2/2] drm: add an fb creation ioctl that takes a pixel format Date: Fri, 11 Nov 2011 07:35:58 -0800 Message-ID: <20111111073558.2f7abf78@jbarnes-desktop> References: <1320787114-5439-1-git-send-email-jbarnes@virtuousgeek.org> <1320787114-5439-2-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0053107242==" Return-path: Received: from oproxy3-pub.bluehost.com (oproxy3-pub.bluehost.com [69.89.21.8]) by gabe.freedesktop.org (Postfix) with SMTP id 613499E7EB for ; Fri, 11 Nov 2011 07:35:39 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0053107242== Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Z8jsFmxARpm48l19CmtwYYY"; protocol="application/pgp-signature" --Sig_/Z8jsFmxARpm48l19CmtwYYY Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, 11 Nov 2011 10:50:00 +0000 Dave Airlie wrote: > On Fri, Nov 11, 2011 at 10:47 AM, Dave Airlie wrote: > > On Tue, Nov 8, 2011 at 9:18 PM, Jesse Barnes = wrote: > >> To properly support the various plane formats supported by different > >> hardware, the kernel must know the pixel format of a framebuffer objec= t. > >> So add a new ioctl taking a format argument corresponding to a fourcc > >> name from videodev2.h. =A0Implement the fb creation hooks in terms of = the > >> new mode_fb_cmd2 using helpers where the old bpp/depth values are > >> needed. > > > > I'm nearly sure I said this before, but please move the FOURCC defines > > somewhere generic, > > then use those, otherwise this is going to encourage crappy userspace > > coding where > > they drag in libv4l2 just to use a drm feature. > > > > I know they are generic, but userspace writes will start to include > > v4l headers to get at > > the same defines you use in the kernel. > > >=20 > Oh and I'll take it as a follow-up patch. as I'd rather merge the base > code now before it gets too late. So just a separate header would be enough for you? include/linux/fourcc or something? Do you care if they continue to use the v4l prefixes or not? My preference would be to preserve that; anything else is just churn for churn's sake. Thanks, --=20 Jesse Barnes, Intel Open Source Technology Center --Sig_/Z8jsFmxARpm48l19CmtwYYY Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iQIcBAEBAgAGBQJOvUDeAAoJEIEoDkX4Qk9hVWMQAIg+U581p3x+ER/rvAIs+JdI +fds3mtoOC9BBX8kTeSynKWrFL1GNjVu4y3+0CxdXkr4AyM4T6pobxkctLEn3ERa sxw16a91KB5fevA3SuflweuiEEBgZBMbW0DFmu4lSzSqXxyLS7E3N3B7N7EJ0oLd dQyNwsDrQ9J7R+31FsdXMRjiSm31C4XOkbIrczbmbw5/psciWNGEDba1J8lAlYlu +AYQm8oFgy7Qdb9fo3cpC6R/gEjaP1cJcXs2deRaoZhWwmVO15tAHeuFCDD+UEce k4OLaitai1dfwxTcxv+R4Tu34x5/lkXNKZbd6Myubw71dG9pmKrEUkq+W62o6P0b A2fkyG4yJjvmv9N2phj+C6KapnQdN/dPHrxLOY66yZQkq/JA3yg8gTWJ5gCQmWM8 uuO0VnujpKFmxxGtWXSdCyE3bcMK9Qhmf7liQqMU0g0IRwJrWRE9AA3yV2FGE1UH gb4+YRJTehiMOzQhlFk0VxYd/afjR7lvl3qf0Q32FYyAPPnnjOUryQJl9FyE7NG3 jl6gx3QqgN6LpWr0O7WRRxv33FbhiGo3LMpiLgr+7HhgI7FIKyMvDS9etdo0se2R 6z/uNnIla6gRY7ImlBttqCLt+ZUT2j+f0DxttjLRnOSgi8eTFr23VcFOm+etf3tr FiFugVIah1u9Os1mS9ZD =/t4r -----END PGP SIGNATURE----- --Sig_/Z8jsFmxARpm48l19CmtwYYY-- --===============0053107242== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel --===============0053107242==--