From mboxrd@z Thu Jan  1 00:00:00 1970
From: Simon Farnsworth <simon.farnsworth@onelan.co.uk>
Subject: Re: [PATCH 1/3] drm/radeon/kms: add some loop timeouts in pageflip
	code
Date: Tue, 29 Nov 2011 11:10:13 +0000
Message-ID: <201111291110.13775.simon.farnsworth@onelan.co.uk>
References: <1322509768-20612-1-git-send-email-alexdeucher@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from claranet-outbound-smtp01.uk.clara.net
	(claranet-outbound-smtp01.uk.clara.net [195.8.89.34])
	by gabe.freedesktop.org (Postfix) with ESMTP id D0BF49EB48
	for <dri-devel@lists.freedesktop.org>;
	Tue, 29 Nov 2011 04:10:29 -0800 (PST)
In-Reply-To: <1322509768-20612-1-git-send-email-alexdeucher@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: dri-devel@lists.freedesktop.org
Cc: Alex Deucher <alexander.deucher@amd.com>, stable@kernel.org, Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
List-Id: dri-devel@lists.freedesktop.org

I've tested all three patches in this series, on an AMD E-350 platform.

1/3 is essential to prevent a complete system hang if the GPU needs
resetting during a page flip; the disaster case is this endless loop running
on core 0, and RCU on core 1 waiting for core 0 to idle.

The remaining two need matching patches to the DDX to be useful, and expose
bugs in Mesa as well.

Tested-by: Simon Farnsworth <simon.farnsworth@onelan.co.uk>

On Monday 28 November 2011, alexdeucher@gmail.com wrote:
> From: Alex Deucher <alexander.deucher@amd.com>
> 
> Avoid infinite loops waiting for surface updates if a GPU
> reset happens while waiting for a page flip.
> 
> See:
> https://bugs.freedesktop.org/show_bug.cgi?id=43191
> 
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: stable@kernel.org
> Cc: Mario Kleiner <mario.kleiner@tuebingen.mpg.de>
> ---
>  drivers/gpu/drm/radeon/evergreen.c |    7 ++++++-
>  drivers/gpu/drm/radeon/r100.c      |    7 ++++++-
>  drivers/gpu/drm/radeon/rs600.c     |    7 ++++++-
>  drivers/gpu/drm/radeon/rv770.c     |    7 ++++++-
>  4 files changed, 24 insertions(+), 4 deletions(-)
> 

-- 
Simon Farnsworth
Software Engineer
ONELAN Limited
http://www.onelan.com/