From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 08/23] drm/via: use drm_mm instead of drm_sman Date: Mon, 12 Dec 2011 23:51:02 +0100 Message-ID: <20111212225102.GE6832@phenom.ffwll.local> References: <1319713670-7475-1-git-send-email-daniel.vetter@ffwll.ch> <1319713670-7475-9-git-send-email-daniel.vetter@ffwll.ch> <20111027210009.GA4876@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-bw0-f49.google.com (mail-bw0-f49.google.com [209.85.214.49]) by gabe.freedesktop.org (Postfix) with ESMTP id 9E20F9F669 for ; Mon, 12 Dec 2011 14:49:27 -0800 (PST) Received: by bkat2 with SMTP id t2so5176818bka.36 for ; Mon, 12 Dec 2011 14:49:26 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: James Simmons Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Dec 07, 2011 at 04:28:45PM +0000, James Simmons wrote: > > > Chris Wilson rightly complained that this doesn't explain the list_del > > magic going on. New commit msg reads: > > > > To make the transition in a piece-wise and bisectable way possible, > > I've hijacked the ->owner_list from drm_sman. While transitioning, the > > list_add was done by the driver, while the list_del was still done by > > the dying sman code. > > > > Now that we are in full control of ->owner_list, do the list_del > > ourselves. > > > > He also noted the superflous additions of INIT_LIST_HEAD and the stale > > comment about spinlock locking in the idr allocation (protected by > > dev->struct_mutex) that I've copied over. All fixed up and pushed out for > > the moment to my fdo repo: > > > > http://cgit.freedesktop.org/~danvet/drm/log/?h=kill-with-fire > > Speaking of I attempted to clone that repo but it gives me > > warning: remote HEAD refers to nonexistent ref, unable to checkout. It's a headless git repo, so you have to check out a specific branch explicitly. Simplest way to do so is with git fetch in an exisiting lk git checkout which should grab that branch into FETCH_HEAD. Then you can check it out, merge it, ... -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48