From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: introduce drm_can_sleep and use in intel/radeon drivers. Date: Thu, 5 Jan 2012 17:00:52 +0100 Message-ID: <20120105160051.GE3831@phenom.ffwll.local> References: <1325757476-19469-1-git-send-email-airlied@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 144A7A091F for ; Thu, 5 Jan 2012 07:58:52 -0800 (PST) Received: by wibhq15 with SMTP id hq15so556776wib.36 for ; Thu, 05 Jan 2012 07:58:52 -0800 (PST) Content-Disposition: inline In-Reply-To: <1325757476-19469-1-git-send-email-airlied@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jan 05, 2012 at 09:57:56AM +0000, Dave Airlie wrote: > From: Dave Airlie > = > So we have a few places where the drm drivers would like to sleep to > be nice to the system, mainly in the modesetting paths, but we also > have two cases were atomic modesetting must take place, panic writing > and kernel debugger. So provide a central inline to determine if a > sleep or delay should be used and use this in the intel and radeon driver= s. > = > Based on patch from Michel D=E4nzer > = > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D43941 > = > Signed-off-by: Dave Airlie If MSLEEP is indeed unused, I think it should just die - we have way too much yelling cruft from dri1 yonder lying around that hides important details like this. Otherwise Reviewed-by: Daniel Vetter -- = Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48