From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] gpu, drm, sis: Don't return uninitialized variable from sis_driver_load() Date: Sun, 15 Jan 2012 01:09:20 +0100 Message-ID: <20120115000920.GA5750@phenom.ffwll.local> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-ww0-f43.google.com (mail-ww0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTP id B98039E75A for ; Sat, 14 Jan 2012 16:07:18 -0800 (PST) Received: by wgbdr11 with SMTP id dr11so509058wgb.12 for ; Sat, 14 Jan 2012 16:07:17 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Jesper Juhl Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Paul Gortmaker , Dave Airlie , Arjan van de Ven List-Id: dri-devel@lists.freedesktop.org On Sat, Jan 14, 2012 at 09:20:37PM +0100, Jesper Juhl wrote: > In sis_driver_load(), the only use of 'ret' is as the return value > from the function, unfortunately it is never initialized, so the > function just returns garbage when it succeeds. > To fix that, remove the variable and just return 0 directly on success. > > Signed-off-by: Jesper Juhl Woot, not one of mine! Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48