From: Daniel Vetter <daniel@ffwll.ch>
To: "Marc Gariépy" <mgariepy@ubuntu.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: Patch to add hp t5745 thin client to no-lvds list
Date: Tue, 17 Jan 2012 17:31:45 +0100 [thread overview]
Message-ID: <20120117163145.GQ4093@phenom.ffwll.local> (raw)
In-Reply-To: <CAAq+WeUpUehRRSDukWBXL+5TanaEZPp2+USZ1WV1PCF5zYxJPQ@mail.gmail.com>
On Wed, Jan 04, 2012 at 05:50:36PM -0500, Marc Gariépy wrote:
> Sorry for the mistake, i made a typo when correcting the indentation issue
> i had.
> here is the correct patch and also the dmidecode from the thin client.
Signed-Off-by is misssing, see Documentation/SubmittingPatches. Also
please combine this with the other no-lvds patch. I'd also like Adam to
ack it, so put him on cc when resubmitting.
-Daniel
>
> --- linux-3.2.0/drivers/gpu/drm/i915/intel_lvds.c 2011-12-24
> 10:23:08.000000000 -0500
> +++ intel_lvds.c 2012-01-04 14:03:49.134573275 -0500
> @@ -723,6 +723,14 @@
> DMI_MATCH(DMI_BOARD_NAME, "AT5NM10T-I"),
> },
> },
> + {
> + .callback = intel_no_lvds_dmi_callback,
> + .ident = "Hewlett-Packard t5745",
> + .matches = {
> + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
> + DMI_MATCH(DMI_BOARD_NAME, "hp t5745"),
> + },
> + },
>
> { } /* terminating entry */
> };
>
>
> On Wed, Jan 4, 2012 at 2:58 PM, Adam Jackson <ajax@redhat.com> wrote:
>
> > On Wed, 2012-01-04 at 14:08 -0500, Marc Gariépy wrote:
> > > Hello,
> > >
> > > I've been directed here by Stephane Graber. I need to blacklist the
> > > LVDS port on some hp t5745 thin client.
> > >
> > > Here is the bug link:
> > > https://bugs.launchpad.net/bugs/911916
> >
> > Does this actually work? The bug above doesn't include the dmidecode
> > output, and...
> >
> > > + DMI_MATCH(DMI_BOARD_VENDOR, "Hewlett-Packard"),
> > > + DMI_MATCH(DMI_BOARD_NAME, "hp st5745"),
> >
> > I would normally expect HP to capitalize their own name correctly.
> >
> > - ajax
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Mail: daniel@ffwll.ch
Mobile: +41 (0)79 365 57 48
next prev parent reply other threads:[~2012-01-17 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-04 19:08 Patch to add hp t5745 thin client to no-lvds list Marc Gariépy
2012-01-04 19:58 ` Adam Jackson
2012-01-04 22:50 ` Marc Gariépy
2012-01-17 16:31 ` Daniel Vetter [this message]
2012-01-23 16:32 ` Adam Jackson
2012-01-26 13:38 ` Marc Gariépy
2012-02-03 21:48 ` Marc Gariépy
2012-02-09 14:35 ` [PATCH] Ignore LVDS on hp t5745 and hp st5747 thin client Marc Gariepy
2012-02-13 8:42 ` Daniel Vetter
2012-02-22 16:29 ` Daniel Vetter
2012-02-22 21:00 ` Keith Packard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120117163145.GQ4093@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mgariepy@ubuntu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox