From: Greg KH <greg@kroah.com>
To: Thomas Hellstrom <thellstrom@vmware.com>
Cc: airlied@redhat.com, stable@vger.kernel.org,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: Fix authentication kernel crash
Date: Tue, 24 Jan 2012 09:12:55 -0800 [thread overview]
Message-ID: <20120124171255.GC26908@kroah.com> (raw)
In-Reply-To: <1327397506-2979-1-git-send-email-thellstrom@vmware.com>
On Tue, Jan 24, 2012 at 10:31:46AM +0100, Thomas Hellstrom wrote:
> If the master tries to authenticate a client using drm_authmagic and
> that client has already closed its drm file descriptor,
> either wilfully or because it was terminated, the
> call to drm_authmagic will dereference a stale pointer into kmalloc'ed memory
> and corrupt it.
>
> Typically this results in a hard system hang.
>
> This patch fixes that problem by removing any authentication tokens
> (struct drm_magic_entry) open for a file descriptor when that file
> descriptor is closed.
>
> Signed-off-by: Thomas Hellstrom <thellstrom@vmware.com>
> ---
> Please review. This should also go into stable kernels.
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
next prev parent reply other threads:[~2012-01-24 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 9:31 [PATCH] drm: Fix authentication kernel crash Thomas Hellstrom
2012-01-24 14:47 ` Daniel Vetter
2012-01-25 17:26 ` Thomas Hellstrom
2012-01-24 17:12 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-24 17:54 Thomas Hellstrom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120124171255.GC26908@kroah.com \
--to=greg@kroah.com \
--cc=airlied@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
--cc=thellstrom@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox