From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Semwal, Sumit" <sumit.semwal@ti.com>
Cc: dri-devel@lists.freedesktop.org, t.stanislaws@samsung.com,
linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org
Subject: Re: [PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op
Date: Tue, 31 Jan 2012 10:42:59 +0100 [thread overview]
Message-ID: <201201311042.59917.laurent.pinchart@ideasonboard.com> (raw)
In-Reply-To: <CAB2ybb8RX5Sy7-s4-X2cLC9HcoTmsn_miYu0HysjHSU4aZ4BBw@mail.gmail.com>
Hi Sumit,
> On Friday 27 January 2012 10:43:28 Sumit Semwal wrote:
[snip]
> static inline void dma_buf_unmap_attachment(struct dma_buf_attachment
> *attach,
> - struct sg_table *sg)
> + struct sg_table *sg, enum dma_data_direction write)
On a second thought, would it make sense to store the direction in struct
dma_buf_attachment in dma_buf_map_attachment(), and pass the value directly to
the .unmap_dma_buf() instead of requiring the dma_buf_unmap_attachment()
caller to remember it ? Or is an attachment allowed to map the buffer several
times with different directions ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-01-31 9:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 9:43 [PATCH] dma-buf: add dma_data_direction to unmap dma_buf_op Sumit Semwal
2012-01-27 15:49 ` Daniel Vetter
2012-01-30 14:19 ` Laurent Pinchart
2012-01-31 5:49 ` Semwal, Sumit
2012-01-31 9:42 ` Laurent Pinchart [this message]
2012-01-31 10:36 ` Daniel Vetter
2012-02-02 10:04 ` Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2012-01-27 9:34 Sumit Semwal
2012-01-27 9:36 ` Semwal, Sumit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201201311042.59917.laurent.pinchart@ideasonboard.com \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@ti.com \
--cc=t.stanislaws@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox