From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: re: drm/i915: switch ring->id to be a real id Date: Thu, 16 Feb 2012 09:40:04 +0300 Message-ID: <20120216064004.GA23794@elgon.mountain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EAC09E740 for ; Wed, 15 Feb 2012 22:40:16 -0800 (PST) Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: daniel.vetter@ffwll.ch Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hello Daniel Vetter, The patch 96154f2faba5: "drm/i915: switch ring->id to be a real id" from Dec 14, 2011, leads to the following warning: drivers/gpu/drm/i915/i915_debugfs.c:688 print_error_buffers() error: err->ring is never equal to -1 (wrong type 0 - 15). @@ -724,6 +724,7 @@ static void print_error_buffers(struct seq_file *m, tiling_flag(err->tiling), dirty_flag(err->dirty), purgeable_flag(err->purgeable), + err->ring != -1 ? " " : "", ^^^^^^^^^^^^^^^ ->ring is an unsigned bitfield so it's never equal to -1. ring_str(err->ring), cache_level_str(err->cache_level)); regards, dan carpenter