From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm/i915: properly compute dp dithering for user-created modes Date: Tue, 10 Apr 2012 19:23:32 +0200 Message-ID: <20120410172332.GM4115@phenom.ffwll.local> References: <1334046971-22453-1-git-send-email-daniel.vetter@ffwll.ch> <1334047356-22596-1-git-send-email-daniel.vetter@ffwll.ch> <4F8439CD.2020201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <4F8439CD.2020201@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Adam Jackson Cc: Daniel Vetter , Intel Graphics Development , DRI Development , stable@kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, Apr 10, 2012 at 09:46:53AM -0400, Adam Jackson wrote: > On 4/10/12 4:42 AM, Daniel Vetter wrote: > >We've only computed whether we need to fall back to 6bpc due to dp > >link bandwidth constrains in mode_valid, but not mode_fixup. Under > >various circumstances X likes to create new modes which then lack > >proper 6bpc flags (if required), resulting in mode_fixup failures and > >ultimately black screens. > > > >Chris Wilson pointed out that we still get things wrong for bpp > 24, > >but that should be fixed in another patch (and it'll be easier because > >this patch consolidates the logic). > > Certainly an improvement. > > Reviewed-by: Adam Jackson I've picked this up for -fixes, thanks for the review. -Daniel -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48