From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC v2 2/5] tps6586x: Add device tree support Date: Wed, 25 Apr 2012 12:14:29 +0200 Message-ID: <20120425101429.GA5085@avionic-0098.mockup.avionic-design.de> References: <1335347102-14905-1-git-send-email-thierry.reding@avionic-design.de> <1335347102-14905-3-git-send-email-thierry.reding@avionic-design.de> <20120425101031.GH3195@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="a8Wt8u1KmwUX3Y2C" Return-path: Content-Disposition: inline In-Reply-To: <20120425101031.GH3195-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Stephen Warren , Olof Johansson , Colin Cross , Jon Mayo , Terje =?utf-8?Q?Bergstr=C3=B6m?= , Lucas Stach , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, David Airlie , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, Joerg Roedel , Hiroshi Doyu , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Grant Likely , Rob Herring , Liam Girdwood , Ben Dooks , Wolfram Sang , linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rhyland Klein List-Id: dri-devel@lists.freedesktop.org --a8Wt8u1KmwUX3Y2C Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Mark Brown wrote: > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > This commit adds device tree support for the TPS6586x regulator. > >=20 > > Signed-off-by: Thierry Reding >=20 > This looks basically good from a quick scan through but the pattern of > looking up regulator nodes by name is very common so should be factored > out - I made a similar comment in response to a recent patch from > Rhyland Klein and earlier today he posted a patch "regulator: add > generic of node parsing for regulators" which does just that. Can you > please redo this on top of his code? I'll probably apply it later > today, though I didn't properly read the code yet. I'll take a look. > I guess it should be possible to apply this patch independantly of the > rest of the series? It shouldn't break bisection if it's missing as > it's a new driver that's being added as the consumer. Yes, it can be applied independently. Thierry --a8Wt8u1KmwUX3Y2C Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAk+XzoUACgkQZ+BJyKLjJp9elACdGhwj2Ee0Mtyus9cds6t2D3Qh TB4An0Pz3mmUIUQ8HmWjISnHC15b8WqE =W/fl -----END PGP SIGNATURE----- --a8Wt8u1KmwUX3Y2C--