From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thierry Reding Subject: Re: [RFC v2 2/5] tps6586x: Add device tree support Date: Wed, 25 Apr 2012 12:41:47 +0200 Message-ID: <20120425104147.GB5085@avionic-0098.mockup.avionic-design.de> References: <1335347102-14905-1-git-send-email-thierry.reding@avionic-design.de> <1335347102-14905-3-git-send-email-thierry.reding@avionic-design.de> <20120425101031.GH3195@opensource.wolfsonmicro.com> <20120425101429.GA5085@avionic-0098.mockup.avionic-design.de> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3185086989945513395==" Return-path: In-Reply-To: <20120425101429.GA5085-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: Mark Brown Cc: Terje =?utf-8?Q?Bergstr=C3=B6m?= , David Airlie , devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, Jon Mayo , iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ben Dooks , Colin Cross , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Liam Girdwood List-Id: dri-devel@lists.freedesktop.org --===============3185086989945513395== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="v9Ux+11Zm5mwPlX6" Content-Disposition: inline --v9Ux+11Zm5mwPlX6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable * Thierry Reding wrote: > * Mark Brown wrote: > > On Wed, Apr 25, 2012 at 11:44:59AM +0200, Thierry Reding wrote: > > > This commit adds device tree support for the TPS6586x regulator. > > >=20 > > > Signed-off-by: Thierry Reding > >=20 > > This looks basically good from a quick scan through but the pattern of > > looking up regulator nodes by name is very common so should be factored > > out - I made a similar comment in response to a recent patch from > > Rhyland Klein and earlier today he posted a patch "regulator: add > > generic of node parsing for regulators" which does just that. Can you > > please redo this on top of his code? I'll probably apply it later > > today, though I didn't properly read the code yet. >=20 > I'll take a look. After taking a closer look I don't think Rhyland's patch is very useful for this driver. I need to lookup the platform ID by regulator name anyway so using the new code is actually more work and requires a second table that lists the regulator names only. Thierry --v9Ux+11Zm5mwPlX6 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iEYEARECAAYFAk+X1OsACgkQZ+BJyKLjJp+lywCgrfrEEWPNFfCrjEjaDMtkhIKZ YYMAn01U23i3etJzrKeugsO4j/ymzuVK =d5pB -----END PGP SIGNATURE----- --v9Ux+11Zm5mwPlX6-- --===============3185086989945513395== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ iommu mailing list iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org https://lists.linuxfoundation.org/mailman/listinfo/iommu --===============3185086989945513395==--