From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jonathan Nieder <jrnieder@gmail.com>
Subject: Re: [PATCH] drm/kms: driver for virtual cirrus under qemu
Date: Sat, 19 May 2012 16:05:51 -0500
Message-ID: <20120519210551.GA24369@burratino>
References: <1335954459-20367-1-git-send-email-airlied@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail-ob0-f177.google.com (mail-ob0-f177.google.com
	[209.85.214.177])
	by gabe.freedesktop.org (Postfix) with ESMTP id CBF419F76A
	for <dri-devel@lists.freedesktop.org>;
	Sat, 19 May 2012 14:06:04 -0700 (PDT)
Received: by obqv19 with SMTP id v19so7469258obq.36
	for <dri-devel@lists.freedesktop.org>;
	Sat, 19 May 2012 14:06:04 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1335954459-20367-1-git-send-email-airlied@gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Dave Airlie <airlied@gmail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

Hi Dave,

Dave Airlie wrote:

> --- /dev/null
> +++ b/drivers/gpu/drm/cirrus/Kconfig
> @@ -0,0 +1,7 @@
> +config DRM_CIRRUS
> +	tristate "Cirrus driver"
> +	depends on DRM && PCI
> +	select FB_CFB_FILLRECT
> +	select FB_CFB_COPYAREA
> +	select FB_CFB_IMAGEBLIT
> +	select DRM_KMS_HELPER

	  MODPOST 139 modules
	ERROR: "sys_copyarea" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	ERROR: "sys_fillrect" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	ERROR: "sys_imageblit" [drivers/gpu/drm/cirrus/cirrus.ko] undefined!
	make[1]: *** [__modpost] Error 1

Would it be too late to squash the following in?

Thanks,
Jonathan

diff --git i/drivers/gpu/drm/cirrus/Kconfig w/drivers/gpu/drm/cirrus/Kconfig
index 0303257ca136..ed6aa703a6d4 100644
--- i/drivers/gpu/drm/cirrus/Kconfig
+++ w/drivers/gpu/drm/cirrus/Kconfig
@@ -1,9 +1,9 @@
 config DRM_CIRRUS_QEMU
 	tristate "Cirrus driver for QEMU emulated device"
 	depends on DRM && PCI && EXPERIMENTAL
-	select FB_CFB_FILLRECT
-	select FB_CFB_COPYAREA
-	select FB_CFB_IMAGEBLIT
+	select FB_SYS_FILLRECT
+	select FB_SYS_COPYAREA
+	select FB_SYS_IMAGEBLIT
 	select DRM_KMS_HELPER
 	help
 	 This is a KMS driver for emulated cirrus device in qemu.