From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH] drm: ignore disconnected <-> unknown status changes Date: Sun, 5 Aug 2012 23:06:11 +0200 Message-ID: <20120805210611.GF12232@phenom.ffwll.local> References: <501A2A6F.4030502@t-online.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail-we0-f177.google.com (mail-we0-f177.google.com [74.125.82.177]) by gabe.freedesktop.org (Postfix) with ESMTP id 9D9BE9E752 for ; Sun, 5 Aug 2012 14:05:52 -0700 (PDT) Received: by weyr3 with SMTP id r3so1755905wey.36 for ; Sun, 05 Aug 2012 14:05:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Alex Deucher Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Fri, Aug 03, 2012 at 09:32:44AM -0400, Alex Deucher wrote: > On Thu, Aug 2, 2012 at 3:21 AM, Knut Petersen wrote: > > On an AOpen i915GMm-hfs the hotplug events generated > > by transitions between connector_status_unknown and > > connector_status_disconnected cause screen distortions. > > > > The attached patch cures the problem by disabling the > > generation of hotplug events in those cases. That should > > be safe for everybody as the only relevant changes are > > those from / to connector_status_connected. > > Seems reasonable to me. We should just drop unknown. We (ab)use that in i915 to avoid some (more costly) load-detection tricks in the hotplug code (but only on rather ancient hw), instead returning unknown. When userspace then inquires the connector status, we flip-flop back to connected. The issue is that we need to avoid these, for the current kms locking would stall the cursor for a while, which is not acceptable to do every 10s. Until the kms locking is fixed, we hence can't drop the unknown state. > Reviewed-by: Alex Deucher Reviewed-by: Daniel Vetter -- Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48