From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH V4 1/2] include/video: move fimd register headers from platform to include/video Date: Tue, 7 Aug 2012 15:25:14 +0000 Message-ID: <201208071525.15032.arnd@arndb.de> References: <1344342872-7904-1-git-send-email-l.krishna@samsung.com> <1344342872-7904-2-git-send-email-l.krishna@samsung.com> <201208071428.56290.arnd@arndb.de> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <201208071428.56290.arnd@arndb.de> Sender: linux-samsung-soc-owner@vger.kernel.org To: linux-arm-kernel@lists.infradead.org Cc: linux-fbdev@vger.kernel.org, kgene.kim@samsung.com, Leela Krishna Amudala , dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, ben-linux@fluff.org, m.szyprowski@samsung.com List-Id: dri-devel@lists.freedesktop.org On Tuesday 07 August 2012, Arnd Bergmann wrote: > On Tuesday 07 August 2012, Leela Krishna Amudala wrote: > > > > This patch moves the contents from regs-fb-v4.h and regs-fb.h to > > include/video/samsung_fimd.h. Also updates the header inclusion in > > machine files and driver files accordingly. > > > > Signed-off-by: Leela Krishna Amudala > > You are missing an explanation here about why the file is moved. > It does seem like a good idea but please say why you do this. > > More importantly, I don't understany why you move regs-fb-v4.h > but not regs-fb.h, which is included by the former. Nevermind, I should have read your text better. Arnd