dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Forest Bond <forest@alittletooquiet.net>
To: David Airlie <airlied@linux.ie>
Cc: dri-devel@lists.freedesktop.org, Alan Cox <alan@linux.intel.com>
Subject: [PATCH 2/3] gma: psb_intel_crtc: Drop crtc_enable flag.
Date: Sat, 11 Aug 2012 08:15:55 -0400	[thread overview]
Message-ID: <20120811121555.GD3089@alittletooquiet.net> (raw)
In-Reply-To: <20120811121454.GC3089@alittletooquiet.net>

From: Forest Bond <forest.bond@rapidrollout.com>

This is set when setting DPMS on and off, but it isn't checked anywhere,
so just remove it.

Signed-off-by: Forest Bond <forest.bond@rapidrollout.com>
---
 drivers/gpu/drm/gma500/cdv_intel_display.c |    2 --
 drivers/gpu/drm/gma500/psb_intel_drv.h     |    1 -
 2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/gma500/cdv_intel_display.c b/drivers/gpu/drm/gma500/cdv_intel_display.c
index 883a9f3..2100aff 100644
--- a/drivers/gpu/drm/gma500/cdv_intel_display.c
+++ b/drivers/gpu/drm/gma500/cdv_intel_display.c
@@ -841,7 +841,6 @@ static void cdv_intel_crtc_dpms(struct drm_crtc *crtc, int mode)
 		/* Give the overlay scaler a chance to enable
 		 * if it's on this pipe */
 		/* psb_intel_crtc_dpms_video(crtc, true); TODO */
-		psb_intel_crtc->crtc_enable = true;
 		break;
 	case DRM_MODE_DPMS_OFF:
 		if (!psb_intel_crtc->active)
@@ -893,7 +892,6 @@ static void cdv_intel_crtc_dpms(struct drm_crtc *crtc, int mode)
 		/* Wait for the clocks to turn off. */
 		udelay(150);
 		cdv_intel_update_watermark(dev, crtc);
-		psb_intel_crtc->crtc_enable = false;
 		break;
 	}
 	/*Set FIFO Watermarks*/
diff --git a/drivers/gpu/drm/gma500/psb_intel_drv.h b/drivers/gpu/drm/gma500/psb_intel_drv.h
index ebe1a28..e179c36 100644
--- a/drivers/gpu/drm/gma500/psb_intel_drv.h
+++ b/drivers/gpu/drm/gma500/psb_intel_drv.h
@@ -190,7 +190,6 @@ struct psb_intel_crtc {
 	u32 mode_flags;
 
 	bool active;
-	bool crtc_enable;
 
 	/* Saved Crtc HW states */
 	struct psb_intel_crtc_state *crtc_state;
-- 
1.7.0.4

  reply	other threads:[~2012-08-11 12:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-11 12:14 [PATCH 1/3] gma500: Fix comment mispelling in cdv_intel_limits definition Forest Bond
2012-08-11 12:15 ` Forest Bond [this message]
2012-08-12 14:04   ` [PATCH 2/3] gma: psb_intel_crtc: Drop crtc_enable flag Forest Bond
2012-08-12 15:25     ` Alan Cox
2012-08-11 12:16 ` [PATCH 3/3] gma500: Consider CRTC initially active Forest Bond

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120811121555.GD3089@alittletooquiet.net \
    --to=forest@alittletooquiet.net \
    --cc=airlied@linux.ie \
    --cc=alan@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox