From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Huacai Chen <chenhuacai@gmail.com>
Cc: Huacai Chen <zltjiangshi@gmail.com>, Hua Yan <yanh@lemote.com>,
Hongliang Tao <taohl@lemote.com>,
dri-devel@lists.freedesktop.org, Huacai Chen <chenhc@lemote.com>
Subject: Re: [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured.
Date: Mon, 13 Aug 2012 14:01:50 -0400 [thread overview]
Message-ID: <20120813180150.GD26088@phenom.dumpdata.com> (raw)
In-Reply-To: <1344849963-22836-1-git-send-email-chenhc@lemote.com>
On Mon, Aug 13, 2012 at 05:26:03PM +0800, Huacai Chen wrote:
> When SWIOTLB is configured, if without this patch kernel compilation
> fails with such error messages:
>
> drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_populate':
> drivers/gpu/drm/radeon/radeon_ttm.c:606:2: error: implicit declaration of function 'swiotlb_nr_tbl'
> drivers/gpu/drm/radeon/radeon_ttm.c:607:3: warning: passing argument 2 of 'ttm_dma_populate' from incompatible pointer type
> include/drm/ttm/ttm_page_alloc.h:81:12: note: expected 'struct device *' but argument is of type 'struct device *'
> drivers/gpu/drm/radeon/radeon_ttm.c: In function 'radeon_ttm_tt_unpopulate':
> drivers/gpu/drm/radeon/radeon_ttm.c:653:3: warning: passing argument 2 of 'ttm_dma_unpopulate' from incompatible pointer type
> include/drm/ttm/ttm_page_alloc.h:82:13: note: expected 'struct device *' but argument is of type 'struct device *'
>
> Signed-off-by: Huacai Chen <chenhc@lemote.com>
> Signed-off-by: Hongliang Tao <taohl@lemote.com>
> Signed-off-by: Hua Yan <yanh@lemote.com>
> Cc: dri-devel@lists.freedesktop.org
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> drivers/gpu/drm/radeon/radeon_ttm.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 5b71c71..fc3ac22 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -41,6 +41,10 @@
> #include "radeon_reg.h"
> #include "radeon.h"
>
> +#ifdef CONFIG_SWIOTLB
> +#include <linux/swiotlb.h>
> +#endif
> +
> #define DRM_FILE_PAGE_OFFSET (0x100000000ULL >> PAGE_SHIFT)
>
> static int radeon_ttm_debugfs_init(struct radeon_device *rdev);
> --
> 1.7.7.3
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2012-08-13 18:11 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-13 9:26 [PATCH] drm/radeon: Include swiotlb.h if SWIOTLB configured Huacai Chen
2012-08-13 18:01 ` Konrad Rzeszutek Wilk [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-08-13 2:09 Huacai Chen
2012-08-13 7:00 ` Paul Menzel
2012-08-13 7:16 ` Huacai Chen
2012-08-13 7:50 ` Paul Menzel
2012-08-13 8:04 ` Huacai Chen
2012-08-13 9:11 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120813180150.GD26088@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=chenhc@lemote.com \
--cc=chenhuacai@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=taohl@lemote.com \
--cc=yanh@lemote.com \
--cc=zltjiangshi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox