Re: [PATCH V6] drm: edid: add support for E-DDC

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Thu, Aug 30, 2012 at 12:34:06PM +0530, Shirish S wrote:
> @@ -276,15 +283,21 @@ drm_do_probe_ddc_edid(struct i2c_adapter *adapter, unsigned char *buf,
>  				.buf	= buf,
>  			}
>  		};
> -		ret = i2c_transfer(adapter, msgs, 2);
> +
> +	/*
> +	 * Avoid sending the segment addr to not upset non-compliant ddc
> +	 * monitors.
> +	 */

Indentation is still wrong. Or is it gettimg mangled by some email server?

> +		ret = i2c_transfer(adapter, &msgs[3 - xfers], xfers);
> +
>  		if (ret == -ENXIO) {
>  			DRM_DEBUG_KMS("drm: skipping non-existent adapter %s\n",
>  					adapter->name);
>  			break;
>  		}
> -	} while (ret != 2 && --retries);
> +	} while (ret != xfers && --retries);
>  
> -	return ret == 2 ? 0 : -1;
> +	return ret == xfers ? 0 : -1;
>  }
>  
>  static bool drm_edid_is_zero(u8 *in_edid, int length)

-- 
Ville Syrjälä
Intel OTC