Re: [PATCH] drm: reduce default drm vblank off delay to 50ms

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Tue, 30 Oct 2012 20:20:44 +0100
Daniel Vetter <daniel@ffwll.ch> wrote:

> On Tue, Oct 30, 2012 at 8:09 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > People keep whining about this, but no one seems to send a patch.  This
> > *ought* to be safe now that we've dealt with the hw races in Mario's
> > updated code, and fixed the bugs we know about in VT switch, DPMS, and
> > multi-head configuraions.
> >
> > Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
> 
> Afaik the fundamental race of enabling the vblank is still there, so
> this is just duct-tape. And our hw has the required registers (on
> gen5+ at least) to close this race for real and abolish all "disable
> vblank irq later to paper over races and smooth things out). Hence I
> think we should dtrt and so
> 
> Nacked-by: Daniel Vetter <daniel@ffwll.ch>
> 
> Also discussed with Jesse on irc, we've had fun ;-)

That's ridiculous.  Just because we have a race we can't fix wrt
reading hw regs, doesn't mean we can't reduce the timeout.

I nack your nack.

-- 
Jesse Barnes, Intel Open Source Technology Center