From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] drm: reduce default drm vblank off delay to 50ms Date: Tue, 30 Oct 2012 12:28:48 -0700 Message-ID: <20121030122848.1cb10f06@jbarnes-desktop> References: <1351624152-8219-1-git-send-email-jbarnes@virtuousgeek.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy8-pub.bluehost.com (oproxy8-pub.bluehost.com [69.89.22.20]) by gabe.freedesktop.org (Postfix) with SMTP id 998E9A0E2D for ; Tue, 30 Oct 2012 12:28:41 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Tue, 30 Oct 2012 20:20:44 +0100 Daniel Vetter wrote: > On Tue, Oct 30, 2012 at 8:09 PM, Jesse Barnes wrote: > > People keep whining about this, but no one seems to send a patch. This > > *ought* to be safe now that we've dealt with the hw races in Mario's > > updated code, and fixed the bugs we know about in VT switch, DPMS, and > > multi-head configuraions. > > > > Signed-off-by: Jesse Barnes > > Afaik the fundamental race of enabling the vblank is still there, so > this is just duct-tape. And our hw has the required registers (on > gen5+ at least) to close this race for real and abolish all "disable > vblank irq later to paper over races and smooth things out). Hence I > think we should dtrt and so > > Nacked-by: Daniel Vetter > > Also discussed with Jesse on irc, we've had fun ;-) That's ridiculous. Just because we have a race we can't fix wrt reading hw regs, doesn't mean we can't reduce the timeout. I nack your nack. -- Jesse Barnes, Intel Open Source Technology Center