Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode

From: Thierry Reding <thierry.reding@avionic-design.de>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: set the AVI VIC of the HDMI mode
Date: Fri, 23 Nov 2012 14:50:37 +0100	[thread overview]
Message-ID: <20121123135037.GA2612@avionic-0098.adnet.avionic-design.de> (raw)
In-Reply-To: <CA+gsUGR45KqbjY=vbyCX20F6v4O0Xd5fjd0J6CegDbqc+gyHGw@mail.gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1045 bytes --]

On Fri, Nov 23, 2012 at 11:46:10AM -0200, Paulo Zanoni wrote:
> Hi
> 
> 2012/11/22 Thierry Reding <thierry.reding@avionic-design.de>:
> > On Wed, Nov 21, 2012 at 01:39:48PM -0200, Paulo Zanoni wrote:
[...]
> >> + * @mode: mode
> >> + *
> >> + * RETURNS:
> >> + * The VIC number, 0 in case it's not a CEA-861 mode.
> >> + */
> >> +uint8_t drm_mode_cea_vic(const struct drm_display_mode *mode)
> >
> > I understand the reason for returning an uint8_t here, but ...
> >
> >> +{
> >> +     uint8_t i;
> >> +
> >> +     for (i = 0; i < drm_num_cea_modes; i++)
> >
> > ... maybe unsigned int would be better for the iteration variable here.
> > Looking at drm_edid_modes.h, drm_num_cea_modes is actually signed, which
> > isn't necessary to store an array size, so maybe that should be changed
> > as well.
> 
> I used uint8_t because "i" is the thing we return. I don't think
> there's a perfect solution to this problem and I don't really think it
> matters too much.

Fair enough, uint8_t should work fine.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel