From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: Re: [PATCH RESEND 3/6] clk: exynos: Fix incorrect usage of IS_ERR_OR_NULL Date: Tue, 18 Dec 2012 22:03:34 +0300 Message-ID: <20121218190334.GK5032@mwanda> References: <1355852048-23188-1-git-send-email-linux@prisktech.co.nz> <1355852048-23188-4-git-send-email-linux@prisktech.co.nz> <20121218183944.GH5032@mwanda> <1355856767.23479.3.camel@gitbox> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from userp1040.oracle.com (userp1040.oracle.com [156.151.31.81]) by gabe.freedesktop.org (Postfix) with ESMTP id D77BCE5C6C for ; Tue, 18 Dec 2012 11:03:45 -0800 (PST) Content-Disposition: inline In-Reply-To: <1355856767.23479.3.camel@gitbox> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Tony Prisk Cc: Mike Turquette , kernel-janitors@vger.kernel.org, Seung-Woo Kim , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kyungmin Park , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org I don't care either way, but being different from the documentation is less bad than crashing which is what your patch does. Please be more careful in the future. regards, dan carpenter