From mboxrd@z Thu Jan  1 00:00:00 1970
From: Markus Trippelsdorf <markus@trippelsdorf.de>
Subject: Re: [PATCH] drm/ttm: fix delayed ttm_bo_cleanup_refs_and_unlock
	delayed handling
Date: Tue, 15 Jan 2013 17:32:02 +0100
Message-ID: <20130115163202.GA220@x4>
References: <50D1CCCB.1070205@canonical.com> <20121219143338.GA221@x4>
	<CADnq5_Mkye_3fN1J=1Udw3mPH+nzn-n7yAjDjzUPX5x=XEGiZg@mail.gmail.com>
	<20121220134539.GA224@x4> <20121220135819.GB224@x4>
	<20130105104129.GA742@x4> <1358261036.29800.31.camel@thor.local>
	<20130115152335.GA220@x4> <1358263615.29800.32.camel@thor.local>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mail.ud10.udmedia.de (ud10.udmedia.de [194.117.254.50])
	by gabe.freedesktop.org (Postfix) with ESMTP id 4FAC7E5C67
	for <dri-devel@lists.freedesktop.org>;
	Tue, 15 Jan 2013 08:32:05 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <1358263615.29800.32.camel@thor.local>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Michel =?iso-8859-1?Q?D=E4nzer?= <michel@daenzer.net>, Jerome Glisse <jglisse@redhat.com>
Cc: Dave Airlie <airlied@redhat.com>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

On 2013.01.15 at 16:26 +0100, Michel D=E4nzer wrote:
> On Die, 2013-01-15 at 16:23 +0100, Markus Trippelsdorf wrote: =

> > On 2013.01.15 at 15:43 +0100, Michel D=E4nzer wrote:
> > > On Sam, 2013-01-05 at 11:41 +0100, Markus Trippelsdorf wrote: =

> > > > On 2012.12.20 at 14:58 +0100, Markus Trippelsdorf wrote:
> > > > > =

> > > > > And just in case it got lost in the noise yesterday: =

> > > > > The image corruption is caused by Dave's commit:
> > > > > =

> > > > > commit dd54fee7d440c4a9756cce2c24a50c15e4c17ccb
> > > > > Author: Dave Airlie <airlied@redhat.com>
> > > > > Date:   Fri Dec 14 21:04:46 2012 +1000
> > > > > =

> > > > >     radeon: fix regression with eviction since evict caching chan=
ges
> > > > > =

> > > > > Reverting it 'fixes' the issue.
> > > > =

> > > > Ping.
> > > > The issue still happens with todays Linus git tree.
> > > =

> > > Does the corruption also occur with
> > > dd54fee7d440c4a9756cce2c24a50c15e4c17ccb applied manually on top of
> > > 0d0b3e7443bed6b49cb90fe7ddc4b5578a83a88d?
> > =

> > No.
> =

> So, can you bisect which change between those two actually introduced
> the corruption?

86a1881d08f65a42c17071a59c0088dbe2870246 is the first bad commit
commit 86a1881d08f65a42c17071a59c0088dbe2870246
Author: Jerome Glisse <jglisse@redhat.com>
Date:   Wed Dec 12 16:43:15 2012 -0500

    drm/radeon: fix fence driver for dma ring when wb is disabled
    =

    The dma ring can't write to register thus have to write to memory
    its fence value. This ensure that it doesn't try to use scratch
    register for dma ring fence driver.
    =

    Should fix:
    https://bugs.freedesktop.org/show_bug.cgi?id=3D58166
    =

    Signed-off-by: Jerome Glisse <jglisse@redhat.com>
    Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

-- =

Markus