From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cong Ding Subject: [PATCH v2] gpu: drm/nouveau/nouveau_fence.c: remove unnecessary null pointer check Date: Tue, 15 Jan 2013 18:19:49 +0100 Message-ID: <20130115171948.GA7211@gmail.com> References: <20130115111451.GB27222@gmail.com> <1358210328-16726-1-git-send-email-dinggnu@gmail.com> <9706.1358246363@warthog.procyon.org.uk> <13598.1358269247@warthog.procyon.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <13598.1358269247@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: David Howells Cc: David Airlie , Ben Skeggs , Dave Airlie , "Paul E. McKenney" , Thomas Gleixner , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org the variable chan is dereferenced in line 190, so it is no reason to check null again in line 198. Signed-off-by: Cong Ding --- drivers/gpu/drm/nouveau/nouveau_fence.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 1d049be..b6b8e49 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fence.c +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c @@ -195,11 +195,9 @@ nouveau_fence_new(struct nouveau_channel *chan, struct nouveau_fence **pfence) return -ENOMEM; kref_init(&fence->kref); - if (chan) { - ret = nouveau_fence_emit(fence, chan); - if (ret) - nouveau_fence_unref(&fence); - } + ret = nouveau_fence_emit(fence, chan); + if (ret) + nouveau_fence_unref(&fence); *pfence = fence; return ret; -- 1.7.10.4