From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesse Barnes Subject: Re: [PATCH] man: Fix typo and use $() for make expressions Date: Fri, 18 Jan 2013 08:54:29 -0800 Message-ID: <20130118085429.30bd595c@jbarnes-desktop> References: <1358511721-22073-1-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from oproxy6-pub.bluehost.com (oproxy6-pub.bluehost.com [67.222.54.6]) by gabe.freedesktop.org (Postfix) with SMTP id 418DFE5C28 for ; Fri, 18 Jan 2013 08:54:40 -0800 (PST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: David Herrmann Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Fri, 18 Jan 2013 17:01:59 +0100 David Herrmann wrote: > On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann > wrote: > > Hi Thierry > > > > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding > > wrote: > >> Due to the typo, none of the .xml files would end up in the release > >> tarball and cause make distcheck as well as builds from the tarball to > >> fail. > >> > >> Using $() isn't strictly necessary but other variables and expressions > >> use that variant already so it makes the usage consistent. > > > > That's weird. "make distcheck" should not be able to build the > > manpages if the XML files are not available. Also ${} is pretty > > standard in makefiles, isn't it? I wonder what the problem here is. At > > least distcheck runs fine on my machine. > > Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why > distcheck works here. But the patch looks fine. Thanks! Works here too. Pushed with David's reviewed-by. Thanks Thierry. -- Jesse Barnes, Intel Open Source Technology Center