From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jesse Barnes <jbarnes@virtuousgeek.org>
Subject: Re: [PATCH] man: Fix typo and use $() for make expressions
Date: Fri, 25 Jan 2013 13:47:12 -0800
Message-ID: <20130125134712.60f87c1c@jbarnes-desktop>
References: <1358511721-22073-1-git-send-email-thierry.reding@avionic-design.de>
	<CANq1E4Rq5ONvGteRLeiFDjWRKLcm4_6=25dSOcGtsmAcO4KWSg@mail.gmail.com>
	<CANq1E4QSQ8yfvangqEqukMhaHcmNztkOnFFUVh-xxNy15vnuyA@mail.gmail.com>
	<20130118085429.30bd595c@jbarnes-desktop>
	<CANq1E4TQLnD_CDARHNiataH6jBAoFxYoifaifGDy0AHC0kGPYw@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from oproxy9.bluehost.com (oproxy9.bluehost.com [69.89.24.6])
	by gabe.freedesktop.org (Postfix) with SMTP id C88DDE6F56
	for <dri-devel@lists.freedesktop.org>;
	Fri, 25 Jan 2013 13:47:24 -0800 (PST)
In-Reply-To: <CANq1E4TQLnD_CDARHNiataH6jBAoFxYoifaifGDy0AHC0kGPYw@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: David Herrmann <dh.herrmann@googlemail.com>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Fri, 25 Jan 2013 16:54:11 +0100
David Herrmann <dh.herrmann@googlemail.com> wrote:

> Hi Jesse
> 
> On Fri, Jan 18, 2013 at 5:54 PM, Jesse Barnes <jbarnes@virtuousgeek.org> wrote:
> > On Fri, 18 Jan 2013 17:01:59 +0100
> > David Herrmann <dh.herrmann@googlemail.com> wrote:
> >
> >> On Fri, Jan 18, 2013 at 5:00 PM, David Herrmann
> >> <dh.herrmann@googlemail.com> wrote:
> >> > Hi Thierry
> >> >
> >> > On Fri, Jan 18, 2013 at 1:22 PM, Thierry Reding
> >> > <thierry.reding@avionic-design.de> wrote:
> >> >> Due to the typo, none of the .xml files would end up in the release
> >> >> tarball and cause make distcheck as well as builds from the tarball to
> >> >> fail.
> >> >>
> >> >> Using $() isn't strictly necessary but other variables and expressions
> >> >> use that variant already so it makes the usage consistent.
> >> >
> >> > That's weird. "make distcheck" should not be able to build the
> >> > manpages if the XML files are not available. Also ${} is pretty
> >> > standard in makefiles, isn't it? I wonder what the problem here is. At
> >> > least distcheck runs fine on my machine.
> >>
> >> Ah sorry, I now saw the "subs" => "subst" typo. Still I wonder why
> >> distcheck works here. But the patch looks fine. Thanks!
> >
> > Works here too.  Pushed with David's reviewed-by.  Thanks Thierry.
> 
> Did you forget to push this patch? I cannot see it in upstream fdo
> libdrm repository. Or maybe I am just looking at the wrong place.

Yeah failed to push, sorry.  Should be there now.

-- 
Jesse Barnes, Intel Open Source Technology Center