From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp Date: Mon, 4 Feb 2013 15:55:51 +0100 Message-ID: <20130204145551.GD5843@phenom.ffwll.local> References: <1359654218-31173-1-git-send-email-ville.syrjala@linux.intel.com> <1359654218-31173-3-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-wg0-f46.google.com (mail-wg0-f46.google.com [74.125.82.46]) by gabe.freedesktop.org (Postfix) with ESMTP id CDD91E6001 for ; Mon, 4 Feb 2013 06:53:39 -0800 (PST) Received: by mail-wg0-f46.google.com with SMTP id fg15so4689221wgb.13 for ; Mon, 04 Feb 2013 06:53:39 -0800 (PST) Content-Disposition: inline In-Reply-To: <1359654218-31173-3-git-send-email-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: ville.syrjala@linux.intel.com, Dave Airlie Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Jan 31, 2013 at 07:43:38PM +0200, ville.syrjala@linux.intel.com wro= te: > From: Ville Syrj=E4l=E4 > = > Support for real RGB332 is a rarity, most hardware only really support > C8. So use C8 instead of RGB332 when determining the format based on > depth/bpp. > = > This fixes 8bpp fbcon on i915, since i915 will only accept C8 and not > RGB332. > = > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D59572 > Signed-off-by: Ville Syrj=E4l=E4 Tested-by: mlsemon35@gmail.com Dave, can you please consider including these two patches into -fixes? The fix a black screen regression when users opt for 8bpp console ... -Daniel > --- > drivers/gpu/drm/drm_crtc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > = > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index ff7344c..826a5ca 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -2253,7 +2253,7 @@ uint32_t drm_mode_legacy_fb_format(uint32_t bpp, ui= nt32_t depth) > = > switch (bpp) { > case 8: > - fmt =3D DRM_FORMAT_RGB332; > + fmt =3D DRM_FORMAT_C8; > break; > case 16: > if (depth =3D=3D 15) > -- = > 1.7.12.4 > = > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch