From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/2] drm: Use C8 instead of RGB332 when determining the format from depth/bpp Date: Thu, 14 Feb 2013 00:45:53 +0100 Message-ID: <20130213234553.GS5813@phenom.ffwll.local> References: <1359654218-31173-1-git-send-email-ville.syrjala@linux.intel.com> <1359654218-31173-3-git-send-email-ville.syrjala@linux.intel.com> <20130204145551.GD5843@phenom.ffwll.local> <20130213124056.GH5813@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: <20130213124056.GH5813@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Dave Airlie Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, Feb 13, 2013 at 01:40:56PM +0100, Daniel Vetter wrote: > On Tue, Feb 05, 2013 at 01:07:01PM +1000, Dave Airlie wrote: > > On Tue, Feb 5, 2013 at 12:55 AM, Daniel Vetter wrote: > > > On Thu, Jan 31, 2013 at 07:43:38PM +0200, ville.syrjala@linux.intel.c= om wrote: > > >> From: Ville Syrj=E4l=E4 > > >> > > >> Support for real RGB332 is a rarity, most hardware only really suppo= rt > > >> C8. So use C8 instead of RGB332 when determining the format based on > > >> depth/bpp. > > >> > > >> This fixes 8bpp fbcon on i915, since i915 will only accept C8 and not > > >> RGB332. > > >> > > >> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D59572 > > >> Signed-off-by: Ville Syrj=E4l=E4 > > > > > > Tested-by: mlsemon35@gmail.com > > > > > > Dave, can you please consider including these two patches into -fixes= ? The > > > fix a black screen regression when users opt for 8bpp console ... > > = > > These are for next, considering what Linus said about -fixes not > > unless they are big. > > = > > so I'll stick a stable cc onto it in next. > = > Ping for merging into drm-next or acking for merging through > drm-intel-next ... Merged both into drm-intel trees for 3.9 with Dave's irc-ack. -Daniel -- = Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch